Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple empty extension functions declared and used, needs to be replaced. #1861

Open
ashwinkey04 opened this issue Dec 2, 2021 · 4 comments

Comments

@ashwinkey04
Copy link

Summary:

Multiple empty extension functions are used for overcoming lint errors, which are potential sources of crashes. Some of them are linked here: [1] [2] [3]

Observed behavior:
Empty extension functions with the below definition occur multiple times.

private fun <E> List<E>.add() {

}

Expected behavior:

Adding these empty extension functions will only overcome the lint errors, but keeping it blank will lead to crashes upon its usages. The variables on which add() function is used need to be changed from immutable data types to mutable ones. Then the built-in addAll() function should be used on those mutable data.

Example: Usage in mifos-mobile.

@avivijay19
Copy link
Collaborator

hello,
wanted to contribute to this issue..!!
can you clarify more on the issue since I am beginner in contribution.

@Pramath02
Copy link

Hey , I am a Kotlin developer and I would be happy to work on this issue. Will be gad to contribute !

@SOUMEN-PAL
Copy link

@avivijay19 hey are you still working on the issue or its fixed.

@TanishMoral11
Copy link

Hey @therajanmaurya @ashwinkey04 , Can I work on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants