You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are here because our integration testing writes actual files to the /create package root, therefore eslint import plugin is able to resolve them in /create/node_modules. This is not ideal. Tests which rely on the scaffolded package's node_modules should run e2e in an isolated temp dir that's not affected by create's node_modules, or in a virtual filesystem where deps are stubbed.
#36 installs some seemingly useless devDependencies:
and
These are here because our integration testing writes actual files to the
/create
package root, therefore eslint import plugin is able to resolve them in/create/node_modules
. This is not ideal. Tests which rely on the scaffolded package's node_modules should run e2e in an isolated temp dir that's not affected by create's node_modules, or in a virtual filesystem where deps are stubbed.Originally posted by @bennypowers in #36 (comment)
The text was updated successfully, but these errors were encountered: