Skip to content

Commit 49ad734

Browse files
committed
Revert a change to a teardown, add a comment instead
1 parent ba41c56 commit 49ad734

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

instrumentation/opentelemetry-instrumentation-httpx/tests/test_httpx_integration.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1020,7 +1020,9 @@ def setUp(self):
10201020
HTTPXClientInstrumentor().instrument_client(self.client)
10211021

10221022
def tearDown(self):
1023-
HTTPXClientInstrumentor().uninstrument_client(self.client)
1023+
# TODO: uninstrument() is required in order to avoid leaks for instrumentations
1024+
# but we should audit the single tests and fix any missing uninstrumentation
1025+
HTTPXClientInstrumentor().uninstrument()
10241026

10251027
def create_proxy_mounts(self):
10261028
return {

0 commit comments

Comments
 (0)