Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Prometheus Operator ScrapeClass. #3600

Open
nicolastakashi opened this issue Jan 10, 2025 · 3 comments
Open

Support Prometheus Operator ScrapeClass. #3600

nicolastakashi opened this issue Jan 10, 2025 · 3 comments
Labels
enhancement New feature or request needs triage

Comments

@nicolastakashi
Copy link
Contributor

Component(s)

target allocator

Is your feature request related to a problem? Please describe.

In the Prometheus Operator, we have developed a cool feature called ScrapeClass, which allows us to define common configurations that are automatically injected into every scrape configuration.

This feature is particularly useful for standardizing configurations such as common relabeling rules, certificates, and other settings. It ensures consistency across monitored objects without requiring users to repeatedly define the same settings for each scrape target.

I’d love to hear your thoughts—do you think this could be a valuable addition to the PrometheusCR integration?

Describe the solution you'd like

Extend TA Config to allow define scrape class structure while using PrometheusCR integration.

Describe alternatives you've considered

No response

Additional context

No response

@nicolastakashi nicolastakashi added enhancement New feature or request needs triage labels Jan 10, 2025
@jaronoff97
Copy link
Contributor

@swiatekm this sounds like exactly what we want for the TA rather than embedding the whole thing in the TA config

@swiatekm
Copy link
Contributor

Sounds good to me. One point worth mentioning is that unlike in prometheus-operator, in a target allocator + otel collector setup, service discovery and scraping happen in different applications. Right now we solve the issue around credentials by encrypting traffic between the target allocator and prometheus receiver, and simply exposing them via target allocator endpoints. Not sure if that makes any difference for scrape classes specifically.

@nicolastakashi
Copy link
Contributor Author

nicolastakashi commented Jan 15, 2025

@swiatekm thanks for mention, I don't see any issue from our side with that, I think it's fine.
I'm going to open a PR extending TA to work with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

3 participants