Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance SNS Publish Batch #2707

Open
dormesica opened this issue Feb 11, 2025 · 1 comment
Open

Enhance SNS Publish Batch #2707

dormesica opened this issue Feb 11, 2025 · 1 comment

Comments

@dormesica
Copy link

Is your feature request related to a problem? Please describe

SNS Publish Batch command is not automatically enhanced

Describe the solution you'd like to see

Same as Message Attributes are added to publish command input, it should be also be added to the different messages published with Publish Batch command.

Describe alternatives you've considered

Additional context

@dormesica
Copy link
Author

dormesica commented Feb 12, 2025

Hi @pichlermarc
Since I need this support I attempted to open a PR for solving this issue (#2710).

I wrote a test for the changes I've made, however the test fails on line 271 on this assertion.

expect(publishSpans.length).toBe(1);

Since I'm new here, perhaps someone could point me to what I'm missing so that I can solve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants