fix(express): span name if middleware on nested router is used #2682
Conversation
|
That is a pretty significant improvement, good job! |
|
Hey there, just wanted to share that I've tried out the changes from this PR by tweaking the OTEL libraries in node_modules for our app, and it sorted out the issues we were facing with |
| * @param [value] the value to push into the array | ||
| */ | ||
| export const storeLayerPath = (request: PatchedRequest, value?: string) => { | ||
| export const storeLayerPath = ( | ||
| request: PatchedRequest, | ||
| value?: string | ||
| ): { isLayerPathStored: boolean } => { |
There was a problem hiding this comment.
This is extremely minor but I can't really think of any other information that could be returned by this, so personally I'd rather see this skip the object and just return a boolean, the meaning of which can be documented in the docstring.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2682 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 171 171
Lines 8150 8152 +2
Branches 1653 1653
=======================================
+ Hits 7532 7534 +2
Misses 618 618
|
Which problem is this PR solving?
Short description of the changes
storeLayerPathfunction, which tells the caller wether a new item has been added to the layer store. This is needed, because we only want to pop from thereq[_LAYERS_STORE_PROPERTY]list if we added something to it. Popping from this list in case we did not push anything to it will result in popping a parent entry, which will skew the layers store. Hence this unnecessary popping will result in a malformed http.route tag.