Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The database connection pool tag value is inconsistent with the document description. #13259

Open
ixiaoyi93 opened this issue Feb 10, 2025 · 1 comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request

Comments

@ixiaoyi93
Copy link

ixiaoyi93 commented Feb 10, 2025

Describe the bug

The value corresponding to the tag pool name is inconsistent with the docs.

Steps to reproduce

You can find it when the service is started.

Expected behavior

As shown in the documentation, the database pool name consists of server.address, server.port, and db.namespace, for example: server.address:server.port/db.namespace.

Actual behavior

The data I queried from prometheus is as follows:

Image

Javaagent or library instrumentation version

v2.12.0, OpenTelemetry SDK 1.46.0.

Environment

JDK: Oracle JDK 1.8.0_341-b10;
OS: Centos 7.9

Additional context

No response

@ixiaoyi93 ixiaoyi93 added bug Something isn't working needs triage New issue that requires triage labels Feb 10, 2025
@trask
Copy link
Member

trask commented Feb 10, 2025

As shown in the documentation, the database pool name consists of server.address, server.port, and db.namespace, for example: server.address:server.port/db.namespace.

I haven't checked the database pool instrumentation, but sometimes it's not possible (or very difficult) to capture some of this data automatically, in which case you may need to instrument those portions manually if you need them.

If you have a chance to look at the database pool instrumentation and send PR to capture those attributes that would be great!

@trask trask added enhancement New feature or request contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome and removed bug Something isn't working needs triage New issue that requires triage labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants