New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The version defined in fluentd CMakeLists not match the version in CHANGELOG #505

Open

zurex opened this issue Dec 10, 2024 · 0 comments

Labels

exporter:fluentd

Contributor

zurex commented Dec 10, 2024 •

edited

Loading

Steps to reproduce

The version defined in fluentd CMakeLists is 1.1.2
- opentelemetry-cpp-contrib/exporters/fluentd/CMakeLists.txt
  
  Line 186 in 6a11053
  
  set(OPENTELEMETRY_CPP_FLUENTD_VERSION "1.1.2")
The version in CHANGELOG is [2.0.0] 2023-06-30
- opentelemetry-cpp-contrib/exporters/fluentd/CHANGELOG.md
  
  Line 16 in 6a11053
  
  ## [2.0.0] 2023-06-30

What is the expected behavior?
set(OPENTELEMETRY_CPP_FLUENTD_VERSION "2.0.0")

What is the actual behavior?
set(OPENTELEMETRY_CPP_FLUENTD_VERSION "1.1.2")

Additional context
What's more, we should support versioned libs since opentelemetry-cpp has such behavior.

Could i raise a PR to address this issue?

The text was updated successfully, but these errors were encountered:

zurex added the exporter:fluentd label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment