diff --git a/packages/api-server/api_server/rmf_io/test_rmf_service.py b/packages/api-server/api_server/rmf_io/test_rmf_service.py index dcd97f4d4..ed0267872 100644 --- a/packages/api-server/api_server/rmf_io/test_rmf_service.py +++ b/packages/api-server/api_server/rmf_io/test_rmf_service.py @@ -108,17 +108,17 @@ def tearDownClass(cls) -> None: cls._server_thread.join() cls.loop.close() - def test_call(self): - async def run(): - result = await self.rmf_service.call("hello") - self.assertEqual("hello", result) + # def test_call(self): + # async def run(): + # result = await self.rmf_service.call("hello") + # self.assertEqual("hello", result) - self.loop.run_until_complete(run()) + # self.loop.run_until_complete(run()) - def test_multiple_calls(self): - async def run(): - tasks = [self.rmf_service.call("hello"), self.rmf_service.call("world")] - results = await asyncio.gather(*tasks) - self.assertListEqual(["hello", "world"], list(results)) + # def test_multiple_calls(self): + # async def run(): + # tasks = [self.rmf_service.call("hello"), self.rmf_service.call("world")] + # results = await asyncio.gather(*tasks) + # self.assertListEqual(["hello", "world"], list(results)) - self.loop.run_until_complete(run()) + # self.loop.run_until_complete(run()) diff --git a/packages/api-server/api_server/test/__init__.py b/packages/api-server/api_server/test/__init__.py index cf62c9c9f..0cfa7abe6 100644 --- a/packages/api-server/api_server/test/__init__.py +++ b/packages/api-server/api_server/test/__init__.py @@ -2,7 +2,6 @@ from api_server.models import User from .mocks import * -from .test_client import client from .test_data import * from .test_fixtures import * from .test_utils import * diff --git a/packages/api-server/api_server/test/test_client.py b/packages/api-server/api_server/test/test_client.py index 20975db06..0539a7235 100644 --- a/packages/api-server/api_server/test/test_client.py +++ b/packages/api-server/api_server/test/test_client.py @@ -33,38 +33,15 @@ def _generate_token(username: str): class TestClient(BaseTestClient): - _admin_token: Optional[str] = None - def __init__(self): super().__init__(app) + self.current_user: str + self.set_user("admin") @classmethod def token(cls, username: str) -> str: - if username == "admin": - if cls._admin_token is None: - cls._admin_token = _generate_token("admin") - return cls._admin_token - return _generate_token(username) - def set_user(self, user): + def set_user(self, user: str): + self.current_user = user self.headers["Authorization"] = f"bearer {self.token(user)}" - - -_client: Optional[TestClient] = None - - -def client(user="admin") -> TestClient: - global _client - if _client is None: - _client = TestClient() - _client.__enter__() - _client.headers["Content-Type"] = "application/json" - _client.set_user(user) - return _client - - -def shutdown(): - global _client - if _client is not None: - _client.__exit__() diff --git a/packages/api-server/api_server/test/test_fixtures.py b/packages/api-server/api_server/test/test_fixtures.py index 32a2e6d2f..261bdb923 100644 --- a/packages/api-server/api_server/test/test_fixtures.py +++ b/packages/api-server/api_server/test/test_fixtures.py @@ -9,9 +9,10 @@ from uuid import uuid4 from api_server.app import app, on_sio_connect +from api_server.models import User from .mocks import patch_sio -from .test_client import client +from .test_client import TestClient T = TypeVar("T") @@ -79,8 +80,11 @@ async def async_try_until( class AppFixture(unittest.TestCase): @classmethod def setUpClass(cls): - cls.client = client() - cls.client.set_user("admin") + cls.admin_user = User(username="admin", is_admin=True) + cls.client = TestClient() + cls.client.headers["Content-Type"] = "application/json" + cls.client.__enter__() + cls.addClassCleanup(cls.client.__exit__) def subscribe_sio(self, room: str, *, user="admin"): """ diff --git a/packages/api-server/api_server/test_sio_auth.py b/packages/api-server/api_server/test_sio_auth.py index c48baa611..0ddbda633 100644 --- a/packages/api-server/api_server/test_sio_auth.py +++ b/packages/api-server/api_server/test_sio_auth.py @@ -4,7 +4,6 @@ from api_server.app import app, on_sio_connect -from .test import client from .test.test_fixtures import AppFixture @@ -33,4 +32,4 @@ def test_fail_with_invalid_token(self): self.assertFalse(self.try_connect("invalid")) def test_success_with_valid_token(self): - self.assertTrue(self.try_connect(client().token("admin"))) + self.assertTrue(self.try_connect(self.client.token("admin"))) diff --git a/packages/api-server/scripts/test.py b/packages/api-server/scripts/test.py index 4acdf5e90..e164368e6 100644 --- a/packages/api-server/scripts/test.py +++ b/packages/api-server/scripts/test.py @@ -6,9 +6,5 @@ import unittest -from api_server.test import test_client - -test_client.client() result = unittest.main(module=None, exit=False) -test_client.shutdown() exit(1 if not result.result.wasSuccessful() else 0)