OpenBMC rebased on upstream yocto which brought in some compiler updates. The new compiler is erroring out on this now when building croserver for OpenBMC:
10:52:04 | ServerSPIInstruction.C: In member function 'virtual uint32_t ServerSPIInstruction::spi_open(Handle**, InstructionStatus&)':
10:52:04 | ServerSPIInstruction.C:66:17: error: ordered comparison of pointer with integer zero ('Handle*' and 'int')
10:52:04 | 66 | if (*handle < 0 || (uint32_t)*handle == 0xFFFFFFFF) {
10:52:04 | | ~~~~~~~~^~~