Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public API entrypoint for the "oracle" (go to definition) feature #7265

Closed
anderseknert opened this issue Jan 14, 2025 · 0 comments · Fixed by #7352
Closed

Add a public API entrypoint for the "oracle" (go to definition) feature #7265

anderseknert opened this issue Jan 14, 2025 · 0 comments · Fixed by #7352

Comments

@anderseknert
Copy link
Member

anderseknert commented Jan 14, 2025

We use this in the Regal language server to provide the "go to definition" feature, but since the oracle package is internal, we're currently using a copy-pasted (and slightly modified / improved) version in Regal. If we exposed this feature in OPA via a public package, we'd be able to avoid maintaining this in more than one place, and improvements would benefit both projects.

anderseknert added a commit to anderseknert/opa that referenced this issue Feb 10, 2025
I'll follow up with another PR to modify this to allow passing
a custom compiler, and whatever else we need in Regal. But moving
files *and* modifying them in the same change is rarely great for
reviewing. So this does nothing but move the package and adjust
the pointer to the package in cmd/oracle.

Fixes open-policy-agent#7265

Signed-off-by: Anders Eknert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant