Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook execution behavior #62

Closed
tcarrio opened this issue Jan 2, 2023 · 0 comments · Fixed by #65
Closed

Hook execution behavior #62

tcarrio opened this issue Jan 2, 2023 · 0 comments · Fixed by #65
Labels
question Further information is requested sdk This issue or pull request relates to an SDK

Comments

@tcarrio
Copy link
Member

tcarrio commented Jan 2, 2023

Please see the open discussion here for more information: open-feature/spec#164

Essentially, some SDKs simply reverse the calculated before hooks (API, Client, Invocation, Provider), and others generate the list with the original lists of Provider, Invocation, Client, and API.

This can result in varying behavior between SDKs.

The preference in the JS SDK is reversal. The Python SDK has also been updated to do reversal. PHP should likely do the same, but there is continuing discussion on the issue linked.

@tcarrio tcarrio added question Further information is requested sdk This issue or pull request relates to an SDK labels Jan 2, 2023
tcarrio added a commit that referenced this issue Jan 2, 2023
Fixes #62

Signed-off-by: Tom Carrio <[email protected]>
@tcarrio tcarrio closed this as completed in 5dc93aa Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested sdk This issue or pull request relates to an SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant