This PR

Hey team, I wrote a more detailed issue (#1025) but here is a summary:

The Flagsmith provider doesn't take into account falsey default values in boolean flags, and it is currently using a fixed truthy value in the code, and the evaluation for these boolean values was based off their existance/enablement, and not their actual value, preventing us from using overrides that change the value, not the enabled status.

This PR includes:

• The fix in resolveBooleanEvaluation to allow boolean flags to use a specified default value;
• The fix in evaluate to ensure boolean flags don't have a special scenario and also consume it's value instead of checking for the existance of the flag;
• Test scenarios that now validate the state value of boolean flags instead of their enablement;
• Additional test scenarios to ensure default values specified outside of constructor default values are also applied and used;

Related Issues

Fixes #1025

Notes

• I took the liberty to make an adjustment to the readme since the suggested contribution command in the flagsmith provider's README wasn't it's actual project name;
• I noticed the provider was written by one of Flagsmith's Founders (@kyle-ssg) and there was a mention in feat: Add Flagsmith Provider #836 regarding the behavior for boolean flags using the enablement status so there may be additional context they may have regarding Flagsmith's expected behavior, but upon using their platform it seemed counterintuitive in this scenario.

Follow-up Tasks

• I haven't identified any follow up tasks, but feel free to flag any you may see.

How to test

• The test scenarios were adjusted to cover the changes, but you may also experiment with the reproducible example, that has the local changes alongside it: https://github.com/uriell/openfeature-flagsmith-boolean-issues