Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add telemetry helper utils #1346

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

liran2000
Copy link
Member

This PR

adds a method to core that returns a semantically valid flag evaluation event

Related Issues

Fixes #1327

Similar to GO PR.

@liran2000 liran2000 requested a review from a team as a code owner February 25, 2025 08:55
Signed-off-by: liran2000 <[email protected]>
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.34%. Comparing base (7df9565) to head (6c67511).

Files with missing lines Patch % Lines
src/main/java/dev/openfeature/sdk/Telemetry.java 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1346      +/-   ##
============================================
+ Coverage     92.80%   93.34%   +0.54%     
- Complexity      466      478      +12     
============================================
  Files            43       45       +2     
  Lines          1125     1157      +32     
  Branches         90       98       +8     
============================================
+ Hits           1044     1080      +36     
+ Misses           53       48       -5     
- Partials         28       29       +1     
Flag Coverage Δ
unittests 93.34% <96.87%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liran2000 liran2000 requested a review from beeme1mr February 25, 2025 09:56
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OpenTelemetry-Compatible Telemetry Utility Function
3 participants