Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Blocking provider mutator #240

Closed
toddbaert opened this issue Dec 13, 2023 · 1 comment · Fixed by #251
Closed

[FEATURE] Blocking provider mutator #240

toddbaert opened this issue Dec 13, 2023 · 1 comment · Fixed by #251
Assignees
Labels
enhancement New feature or request

Comments

@toddbaert
Copy link
Member

toddbaert commented Dec 13, 2023

Requirements

As is recommended by the spec, we should add a blocking version of setProvider. This would wait for the provider to be initialized before it returns. It should be named in such a way that its blocking behavior is obvious, and should be documented appropriately. The README should be update to include it (close to the start) and highlight how it behaves differently from setProvider.

See a PR for a similar feature in Java.

Please be sure to add tests!

Relates to: #238

@Kavindu-Dodan
Copy link
Contributor

I will take over this as the current open PR #244 is not maintained for almost two weeks.

@Kavindu-Dodan Kavindu-Dodan self-assigned this Feb 1, 2024
@Kavindu-Dodan Kavindu-Dodan removed the good first issue Good for newcomers label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants