Trigger tutorial to save one file per trigger

[ChucklesOnGitHub]

Joining our trigger tutorial with our save data tutorial is not straightforward.

Joining them naively yields only one saved file idependently of how many triggers there are.

Looking at how @cjsha solved this for the GUI here, I made a standalone file to update the trigger tutorial for it to be meaninful to save data based on the external trigger.

demo-miniscope-trigger-save.zip

I tested it and it works, but I'd appreciate a review before writing the tutorial since I'm not sure the logic is the simplest.

[ChucklesOnGitHub]

File management here is bad, tho.

If you use file indices, they will be off by one.
If you use timestamps, they might not match.

[cjsha]

demo-miniscope-trigger-save_cs-edits.zip

This workflow fixes the file management, and some logic is also simplified:

• We don't need to split Trigger into two separate "TriggerToggleHigh" and "TriggerToggleLow" PublishSubjects if they just end up getting merged anyway. If this is something I do in the GUI, I should fix that.

• The logic preceding TakeUntil has been simplified using TakeWhile.

• CsvWriter and VideoWriter operate differently. VideoWriter only creates a file if it receives input to actually write. CsvWriter creates a file whenever the containing workflow is subscribed to, even if the file ends up being empty. I created some logic to prevent sending the first notification if trigger is LOW (when SelectMany (e.g. "SaveDataTriggerToggle") receives a notification, it creates a subscription). This is what was causing file indices to mismatch or timestamps not to match: when the workflow is started while Trigger is LOW, an empty CSV would get created This might also need to be fixed in the GUI workflow.

If any of these changes need to be implemented in the GUI workflow, can you please note that in the corresponding issue/PR? PR would probably be better.

[cjsha]

made one more change! All the logic is the same, I just made two separate branches into one contiguous for readability.

demo-miniscope-trigger-save_cs-edits.zip

before:

after:

[cjsha]

One question I guess is if we want a rising edge to trigger a recording or anytime trigger is HIGH. This in effect changes whether a recording starts if trigger is HIGH when the workflow starts.

[ChucklesOnGitHub]

Thanks, I was wondering about all those three things.
The other thing was, could this be simplified using WindowTrigger? (such as here)

One question I guess is if we want a rising edge to trigger a recording or anytime trigger is HIGH. This in effect changes whether a recording starts if trigger is HIGH when the workflow starts.

Hmm I think the latter - any time the line is high, is simpler? I can check what the other software used to do.

[cjsha]

I gave it a shot using WindowTrigger. It's not immediately straightforward. The problem is that it would start chooching notifications into the "projected observable sequence" before the first trigger notification, so we have to gate the input to WindowTrigger until the first trigger occurs.

[cjsha]

I think this might be the most simple:

demo-miniscope-trigger-save_cs-edits.zip

I would of course rename some of the nodes so they're more helpful before publishing. For example that one I named "wah", sorry about that. Also make sure that the videowriter and whatnot properties are as you want, because I probably accidentally changed those in the process.