Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhs2116 - clear stimulus parameters when the Clear button is pressed #394

Closed
bparks13 opened this issue Dec 23, 2024 · 1 comment
Closed
Assignees
Labels
enhancement This feature already exists but could be improved
Milestone

Comments

@bparks13
Copy link
Member

Currently, when the Clear button is pressed, all parameters in the text boxes remain even if the parameters are removed from the channel. While there is a visual update where the stimulus waveform is removed from the plot in the main window, it would probably be more clear what is happening if all of the parameter text boxes are cleared as well.

This also will add the ability to deselect all channels and then press clear to remove any parameters that aren't needed. This would be useful from a user perspective to make it easier to clear parameters if they only want to apply one specific parameter to a channel and don't want to have to click on each text box and delete the contents.

@bparks13 bparks13 added the enhancement This feature already exists but could be improved label Dec 23, 2024
@bparks13 bparks13 added this to the 0.5.0 milestone Dec 23, 2024
@bparks13 bparks13 self-assigned this Dec 23, 2024
@jonnew
Copy link
Member

jonnew commented Jan 6, 2025

Per our discussion:

  1. Clearing the text: maximum amount of work to redefine parameters
  2. Not clearing: amount of work maxes out at case 1, but could be less if some of the parameters are reused.

For this reason, we think we should probably not pursue this issue.

@jonnew jonnew closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This feature already exists but could be improved
Projects
None yet
Development

No branches or pull requests

2 participants