Skip to content

Commit a48d0d1

Browse files
author
oooiik
committed
update empty logic
1 parent 2d02c91 commit a48d0d1

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/Services/FilterService.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ protected function getClientMethods()
4949

5050
protected function getClientDefault(string $key = null)
5151
{
52-
if (empty($key)) {
52+
if ($key === null) {
5353
return empty($this->getClient()->default) ? [] : $this->getClient()->default;
5454
} else {
55-
return empty($this->getClientDefault()[$key]) ? null : $this->getClientDefault()[$key];
55+
return array_key_exists($key, $this->getClientDefault()) ? $this->getClientDefault()[$key] : null;
5656
}
5757
}
5858

@@ -61,7 +61,7 @@ protected function getClientFallback(string $key = null)
6161
if ($key === null) {
6262
return empty($this->getClient()->fallback) ? [] : $this->getClient()->fallback;
6363
} else {
64-
return empty($this->getClientFallback()[$key]) ? null : $this->getClientFallback()[$key];
64+
return array_key_exists($key, $this->getClientFallback()) ? $this->getClientFallback()[$key] : null;
6565
}
6666
}
6767

@@ -75,12 +75,12 @@ protected function setParams($params)
7575
$this->params = array_merge($this->getClientDefault(), $params);
7676
}
7777

78-
protected function getParam($key = null)
78+
protected function getParam(string $key = null)
7979
{
8080
if ($key === null) {
8181
return $this->params;
8282
} else {
83-
return empty($this->params[$key]) ? null : $this->params[$key];
83+
return array_key_exists($key, $this->params) ? $this->params[$key] : null;
8484
}
8585
}
8686

0 commit comments

Comments
 (0)