Skip to content

Cache EventEmitter instances based on event names #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cache EventEmitter instances based on event names #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
780f063
Enforce event names and cache EventEmitter instaces
GeorgeTG Jun 25, 2018
6da49e4
Change to map and follow original code style
GeorgeTG Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,26 @@ export interface IEvent<T> {
subscribe(callback: EventCallback<T>): IDisposable
}

const eventsCache = new Map<string, EventEmitter>()

export class Event<T> implements IEvent<T> {

private _name: string
private _eventObject: EventEmitter = new EventEmitter()

constructor(name?: string) {
this._name = name || "default_event"
private _eventObject: EventEmitter

constructor(name: string) {
this._name = name
if (!eventsCache.has(name)) {
let emitter = new EventEmitter()
emitter.setMaxListeners(100)
eventsCache.set(name, emitter)
}
this._eventObject = eventsCache.get(name)!
}

public subscribe(callback: EventCallback<T>): IDisposable {
this._eventObject.addListener(this._name, callback)

const dispose = () => {
this._eventObject.removeListener(this._name, callback)
}
Expand Down