Skip to content

Commit 0fdc45b

Browse files
author
Fiete Ostkamp
committed
Upgrade onap-ui-common to 1.1.2
1.1.2 carries the WCAG contrast fixes to the shared colour variables and the dropdown caret target size fix, so the library's build and Storybook now render against the styles catalog-ui is moving to. Its index.js now loads the icons map with require('./lib/icons-map.json'), which the UMD build routed through a json-loader rule for a package that was never installed, so build:umd failed with "Can't resolve 'json-loader'". webpack 4 parses JSON natively, so the rule is dropped. The peer range ^1.1.0 already admits 1.1.2 and is left as is; nothing here needs the newer version. package-lock.json only has its onap-ui-common entry updated. 1.1.2 declares engines.node >=20.19; npm 6 on the pinned Node 10 only warns about that. Verified with Node 10: npm install through Nexus, npm run build (same 749 files in dist/) and npm run storybook:build. With Node 18 and the CI test job's install, Jest passes 275/275. Issue-ID: SDC-5031 Change-Id: I32b95e31d9514399671549f35b25dead08a0c739 Signed-off-by: Fiete Ostkamp <fiete.ostkamp@telekom.de>
1 parent 7e6d340 commit 0fdc45b

3 files changed

Lines changed: 4 additions & 9 deletions

File tree

‎package-lock.json‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"css-loader": "^0.28.11",
4646
"jest": "^23.6.0",
4747
"jest-preset-angular": "^6.0.1",
48-
"onap-ui-common": "1.1.0",
48+
"onap-ui-common": "1.1.2",
4949
"rimraf": "^2.6.2",
5050
"rxjs": "6.0.0",
5151
"sass": "~1.48.0",

‎webpack-umd.config.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,6 @@ export default {
4747
]
4848
},
4949

50-
{
51-
test: /\.json$/,
52-
use: 'json-loader'
53-
},
54-
5550
{
5651
test: /\.css$/,
5752
use: ['to-string-loader', 'css-loader']

0 commit comments

Comments
 (0)