clip option has no effect

[LelandB]

Hello, I'm trying out clipping on the demo and I can't seem to make it happen. I've added the following clip array that should bisect the tif.

const windSpeedUrl = "http://127.0.0.1:5500/demo/wind_speed.tif";
  // const windSpeedUrl =
  //   "https://danwild.github.io/leaflet-geotiff-2/wind_speed.tif";

  const plottyRenderer = L.LeafletGeotiff.plotty({
    displayMin: 0,
    displayMax: 10,
    clampLow: false,
    clampHigh: false,
  });

  const clipArray = [[-33, 147], [-27, 147], [-27, 159], [-33, 159]]

  const windSpeedLayer = L.leafletGeotiff(windSpeedUrl, {
    renderer: plottyRenderer,
    clip: clipArray,
  }).addTo(map);

What am I doing wrong?

[danwild]

What am I doing wrong?

Nothing, it seems.

Clipping was disabled a while back by commenting out the createMask call in leaflet-geotiff.js#L463:

// mask caused problems and seems to be not needed for our implementation
// var mask = this.createMask(size, args);

"caused problems" is obviously ambiguous. Next steps - someone needs to identify the problem that clipping was causing, then implement a fix.

The clip option was irrelevant to our immediate use cases when furthering the development of this plugin. This remains the case, so - a PR is welcome here however otherwise this issue is unlikely to receive much focus from our team any time soon.

We should at least document this for now tho!

[danwild]

Also note to self - I think mask would be a more descriptive way to refer to this option (more differentiated from bounds, and proposed bbox options).