Add comment about incorrect using HttpClient

Author: olsh

src/CurlToCSharp.IntegrationTests/CurlToCSharp.IntegrationTests.csproj

@@ -8,7 +8,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="3.9.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
       <PrivateAssets>all</PrivateAssets>

src/CurlToCSharp.UnitTests/CurlToCSharp.UnitTests.csproj

@@ -7,7 +7,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
       <PrivateAssets>all</PrivateAssets>

src/CurlToCSharp/Constants/Chars.cs

@@ -1,4 +1,4 @@
-namespace CurlToCSharp.Constants
+namespace CurlToCSharp.Constants
 {
     public static class Chars
     {
@@ -9,5 +9,7 @@ public static class Chars
         public const char SingleQuote = '\'';
 
         public const char Space = ' ';
+
+        public const string NewLineString = "\n";
     }
 }

src/CurlToCSharp/Extensions/RoslynExtensions.cs

@@ -1,6 +1,8 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Linq;
 
+using CurlToCSharp.Constants;
+
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
@@ -9,8 +11,6 @@ namespace CurlToCSharp.Extensions
 {
     public static class RoslynExtensions
     {
-        private const string NewLineString = "\n";
-
         public static InvocationExpressionSyntax CreateInvocationExpression(
             string leftPart,
             string rightPart,
@@ -132,12 +132,17 @@ public static AssignmentExpressionSyntax CreateMemberAssignmentExpression(
 
         public static TSyntax PrependComment<TSyntax>(this TSyntax node, string comment) where TSyntax : SyntaxNode
         {
-            return node.WithLeadingTrivia(SyntaxFactory.Comment(NewLineString + comment));
+            return node.WithLeadingTrivia(SyntaxFactory.Comment(comment));
         }
 
         public static TSyntax AppendWhiteSpace<TSyntax>(this TSyntax node) where TSyntax : SyntaxNode
         {
-            return node.WithTrailingTrivia(SyntaxFactory.Comment(NewLineString));
+            return node.WithTrailingTrivia(SyntaxFactory.Comment(Chars.NewLineString));
+        }
+
+        public static TSyntax PrependWhiteSpace<TSyntax>(this TSyntax node) where TSyntax : SyntaxNode
+        {
+            return node.WithLeadingTrivia(SyntaxFactory.Comment(Chars.NewLineString));
         }
 
         public static void TryAppendWhiteSpaceAtEnd<TSyntax>(this ICollection<TSyntax> statements) where TSyntax : SyntaxNode

src/CurlToCSharp/Services/ConverterService.cs

@@ -1,9 +1,10 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 using System.Net.Http;
 
+using CurlToCSharp.Constants;
 using CurlToCSharp.Extensions;
 using CurlToCSharp.Models;
 
@@ -506,10 +507,15 @@ private ExpressionStatementSyntax CreateTryAddHeaderStatement(ArgumentSyntax key
         /// </remarks>
         private UsingStatementSyntax CreateHttpClientUsing(CurlOptions curlOptions)
         {
+
             var argumentSyntax = ShouldGenerateHandler(curlOptions)
                                      ? new[] { SyntaxFactory.Argument(SyntaxFactory.IdentifierName(HandlerVariableName)) }
                                      : new ArgumentSyntax[0];
-            return RoslynExtensions.CreateUsingStatement(HttpClientVariableName, nameof(HttpClient), argumentSyntax);
+            var usingStatement = RoslynExtensions.CreateUsingStatement(HttpClientVariableName, nameof(HttpClient), argumentSyntax);
+
+            return usingStatement
+                .PrependComment("// In production code, don't destroy the HttpClient through using, but better reuse an existing instance"
+                + Chars.NewLineString + "// https://www.aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong/");
         }
 
         /// <summary>
@@ -666,10 +672,10 @@ private IEnumerable<MemberDeclarationSyntax> ConfigureHandlerStatements(CurlOpti
                     "AutomaticDecompression",
                     SyntaxFactory.PrefixUnaryExpression(SyntaxKind.BitwiseNotExpression, RoslynExtensions.CreateMemberAccessExpression("DecompressionMethods", "None")));
 
-                memberAssignmentExpression = memberAssignmentExpression.PrependComment("// If you are using .NET Core 3.0+ you can replace `~DecompressionMethods.None` to `DecompressionMethods.All`");
+                memberAssignmentExpression = memberAssignmentExpression
+                    .PrependComment(Chars.NewLineString + "// If you are using .NET Core 3.0+ you can replace `~DecompressionMethods.None` to `DecompressionMethods.All`");
 
-                statementSyntaxs.AddLast(
-                    SyntaxFactory.GlobalStatement(SyntaxFactory.ExpressionStatement(memberAssignmentExpression)));
+                statementSyntaxs.AddLast(SyntaxFactory.GlobalStatement(SyntaxFactory.ExpressionStatement(memberAssignmentExpression)));
             }
 
             if (curlOptions.HasCertificate && IsSupportedCertificate(curlOptions.CertificateType))