-
Notifications
You must be signed in to change notification settings - Fork 31
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
While implementing UI tests for a custom linter, a reviewer noted that it would easier to review rustfix'd files if they had a .rs extension, since that would enable code highlighting when reviewing on Github or other code editors. This would be useful, but would be a breaking change for existing users.
I believe the extension for rustfix'd files is currently hardcoded here:
ui_test/src/custom_flags/rustfix.rs
Lines 73 to 79 in 5b7b0b2
| vec![config.check_output(single.as_bytes(), &mut errors, "fixed")] | |
| } | |
| _ => fixes | |
| .iter() | |
| .enumerate() | |
| .map(|(i, fix)| { | |
| config.check_output(fix.as_bytes(), &mut errors, &format!("{}.fixed", i + 1)) |
Additionally, this would probably require default_file_filter() to be updated to skip .fixed.rs files.
Thanks!
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers