Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double quotes in AWS options cause an error #391

Open
martinrw opened this issue Jan 12, 2022 · 0 comments
Open

Double quotes in AWS options cause an error #391

martinrw opened this issue Jan 12, 2022 · 0 comments

Comments

@martinrw
Copy link

Describe the bug
Using certain options for aws commands (that require double quotes) with okta-aws causes the command to fail

To Reproduce
Steps to reproduce the behavior:
Trying to delete some files from s3 using the include and exclude options:

$ okta-aws sandbox s3 rm s3://martin-test-s3-commands --recursive --dryrun --exclude "*" --include "*.zip"
Unknown options:file1,file2,file3

In this example file1, file2 and file3 are just some files that happen to be in my current working directory

Expected behavior
A clear and concise description of what you expected to happen.
If you run the same command with vanilla aws cli it works:

$ aws s3 rm s3://martin-test-s3-commands --recursive --dryrun --exclude "*" --include "*.zip"
(dryrun) delete: s3://martin-test-s3-commands/dummy1.zip
(dryrun) delete: s3://martin-test-s3-commands/dummy2.zip
(dryrun) delete: s3://martin-test-s3-commands/dummy3.zip

We should be seeing the same result from the okta-aws command

Additional context
Add any other context about the problem here.

There is a workaround but it's not ideal, you can escape the double quotes with a \

$ okta-aws sandbox s3 rm s3://martin-test-s3-commands --recursive --dryrun --exclude \"*\" --include \"*.zip\"
(dryrun) delete: s3://martin-test-s3-commands/dummy1.zip
(dryrun) delete: s3://martin-test-s3-commands/dummy2.zip
(dryrun) delete: s3://martin-test-s3-commands/dummy3.zip

I am using the latest version of Okta-aws-cli (3.0.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant