Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torproxy on v1 doesn't terminate tor on exit, address already on use #28

Open
Raviu56 opened this issue Apr 12, 2020 · 2 comments
Open
Labels
bug Something isn't working

Comments

@Raviu56
Copy link

Raviu56 commented Apr 12, 2020

Is this a BUG REPORT or FEATURE REQUEST?:
bug

What happened:
When I kill - terminate - caddy with torproxy the spawned tor process doesn't terminate.
Which causes caddy to fail on restart as it complains that port 8868 is already is use.

What you expected to happen:
I expect it to either end the child tor process, or to be able to re-use an existing one.

Environment:

  • Torproxy version: Not sure
    Downloaded using wget -O caddy_torproxy.tgz 'https://caddyserver.com/download/linux/amd64?plugins=http.torproxy&license=personal&telemetry=off'
  • Others: caddy 1.0.4
@stp-ip stp-ip added the bug Something isn't working label Apr 12, 2020
@stp-ip
Copy link
Member

stp-ip commented Apr 12, 2020

Feels like a similar issue to the one we had before splitting it out into a separate project.
Might add some more details for @erbesharat txtdirect/txtdirect#245

@erbesharat
Copy link
Member

I used the latest commit on caddy-v1 branch and the Caddy build server binary and after closing torproxy all the opened ports got closed and the Tor instance got shutdown successfully.
I had these ports opened after running torproxy with default configs and they all got closed after shutdown:

tcp        0      0 127.0.0.1:4242          0.0.0.0:*               LISTEN      2106/tor            
tcp        0      0 127.0.0.1:8868          0.0.0.0:*               LISTEN      2096/./torproxy     
tcp        0      0 127.0.0.1:43981         0.0.0.0:*               LISTEN      2106/tor            

I wasn't able to reproduce this bug so it would be awesome if you could provide more information and your config file in case you've changed a default config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants