Skip to content

Commit cbbe949

Browse files
committed
Fixup ruby-3.5 compatibility
`irb`, `logger` & `ostruct` are used by SDK and was moved from default to bundled gems in ruby-3.5 [0]. Add them to the gemspec to fix compatibility. We're using `head` in CI instead of `3.5` because it's closer to the final version, see [1] No `continue-on-error` because we're only testing `gem build` for now, which should work with `head` no matter what. Could be skipped later if needed. Fixes facebook#220 [0] https://bugs.ruby-lang.org/issues/20309 [1] ruby/ruby-builder#4 (comment)
1 parent 0e38977 commit cbbe949

File tree

3 files changed

+26
-1
lines changed

3 files changed

+26
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
strategy:
88
matrix:
99
operating-system: [ubuntu-latest]
10-
version: ['3.0', '3.1', '3.2', '3.3', '3.4']
10+
version: ['3.0', '3.1', '3.2', '3.3', '3.4', 'head']
1111
steps:
1212
- name: Checkout
1313
uses: actions/checkout@v2

Gemfile.lock

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ PATH
77
faraday (~> 2.6)
88
faraday-multipart (~> 1.0, >= 1.0.4)
99
json (~> 2.6)
10+
logger
1011
money (~> 6.13)
12+
ostruct
1113

1214
GEM
1315
remote: https://rubygems.org/
@@ -22,6 +24,7 @@ GEM
2224
unicode_utils (~> 1.4)
2325
countries (5.7.2)
2426
unaccent (~> 0.3)
27+
date (3.4.1)
2528
diff-lcs (1.5.0)
2629
dotenv (2.8.1)
2730
faraday (2.9.2)
@@ -32,26 +35,43 @@ GEM
3235
net-http
3336
i18n (1.14.5)
3437
concurrent-ruby (~> 1.0)
38+
io-console (0.8.0)
39+
irb (1.15.2)
40+
pp (>= 0.6.0)
41+
rdoc (>= 4.0.0)
42+
reline (>= 0.4.2)
3543
json (2.7.2)
44+
logger (1.7.0)
3645
method_source (1.0.0)
3746
minitest (5.14.4)
3847
money (6.19.0)
3948
i18n (>= 0.6.4, <= 2)
4049
multipart-post (2.4.1)
4150
net-http (0.4.1)
4251
uri
52+
ostruct (0.6.1)
4353
parallel (1.22.1)
4454
parser (3.2.0.0)
4555
ast (~> 2.4.1)
56+
pp (0.6.2)
57+
prettyprint
58+
prettyprint (0.2.0)
4659
pry (0.14.2)
4760
coderay (~> 1.1)
4861
method_source (~> 1.0)
4962
pry-coolline (0.2.6)
5063
coolline (~> 0.5)
5164
pry (~> 0.13)
65+
psych (5.2.3)
66+
date
67+
stringio
5268
rainbow (3.1.1)
5369
rake (13.0.6)
70+
rdoc (6.13.1)
71+
psych (>= 4.0.0)
5472
regexp_parser (2.6.2)
73+
reline (0.6.1)
74+
io-console (~> 0.5)
5575
rexml (3.3.3)
5676
strscan
5777
rspec (3.12.0)
@@ -79,6 +99,7 @@ GEM
7999
rubocop-ast (1.24.1)
80100
parser (>= 3.1.1.0)
81101
ruby-progressbar (1.11.0)
102+
stringio (3.1.7)
82103
strscan (3.1.0)
83104
unaccent (0.4.0)
84105
unicode-display_width (1.8.0)
@@ -97,6 +118,7 @@ DEPENDENCIES
97118
byebug (~> 11.0)
98119
dotenv (~> 2.7)
99120
facebookbusiness!
121+
irb
100122
minitest (~> 5.14.2)
101123
pry (~> 0.12)
102124
pry-coolline (~> 0.2)

facebookbusiness.gemspec

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ Gem::Specification.new do |s|
4040
s.add_dependency 'json', '~> 2.6'
4141
s.add_dependency 'countries', '>= 3', '< 7'
4242
s.add_dependency 'money', '~> 6.13'
43+
s.add_dependency 'logger'
44+
s.add_dependency 'ostruct'
4345

4446
s.add_development_dependency 'awesome_print', '~> 1.8'
4547
s.add_development_dependency 'bundler', '~> 2.2'
@@ -51,6 +53,7 @@ Gem::Specification.new do |s|
5153
s.add_development_dependency 'rake', '~> 13.0'
5254
s.add_development_dependency 'rspec', '~> 3.8'
5355
s.add_development_dependency 'rubocop', '~> 0.71'
56+
s.add_development_dependency 'irb'
5457

5558
s.files = Dir['LICENSE.txt', 'README.md', 'lib/**/*', 'bin/*']
5659
s.executables = s.files.grep(%r{^bin/}).map { |f| File.basename(f) }

0 commit comments

Comments
 (0)