Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read logo from branding/square-logo-light.png #121

Open
rgaudin opened this issue Apr 24, 2024 · 6 comments
Open

Read logo from branding/square-logo-light.png #121

rgaudin opened this issue Apr 24, 2024 · 6 comments
Labels
enhancement New feature or request stale
Milestone

Comments

@rgaudin
Copy link
Member

rgaudin commented Apr 24, 2024

With offspot-config 2.2.0, branding folder is mounted onto metrics image at /src/ui/branding (and /src/ui/offspot.branding).

Imager created builds all contain the following files:

  • horizontal-logo-light.png
  • square-logo-light.png

In order to use them, you should:

  • move frontend/public/Kiwix-logo.png into frontend/public/branding/square-logo-light.png
  • use ./branding/square-logo-light.png instead of ./Kiwix-logo.png in your vues
  • make sure logo is constrained into a reasonably-sized square as there is no check on this
width: 1em;
height: 1em;
object-fit: scale-down;
@rgaudin rgaudin added the enhancement New feature or request label Apr 24, 2024
@Popolechien
Copy link

@rgaudin If the logo has to be squared then could horizontal-logo-light.png be replaced with https://commons.wikimedia.org/wiki/File:Logo-kiwix-vertical.svg ?

@rgaudin
Copy link
Member Author

rgaudin commented Apr 24, 2024

@Popolechien I don't understand.

  • hotspot supports two branding images ATM : one horizontal and one squared.
  • metrics doesn't support custom branding images ATM.
  • metrics uses one branding image. It is squared and is the one I mention above.

This ticket is a technical one that's just about moving stuff. We're not introducing new image here ; just possibility for users to have their chosen logo instead of Kiwix's.

If you are unhappy with the default kiwix branding, open a ticket in imager service or offspot-config. Starting tomorrow the default branding will be displayed in configuration editor so it'll be easy to assess for you.

@Popolechien
Copy link

Nevermind then I misunderstood your description.

@benoit74
Copy link
Collaborator

Good to know, thank you for all the details.

@benoit74 benoit74 added this to the 0.4.0 milestone Apr 30, 2024
Copy link

stale bot commented Jun 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jun 30, 2024
@benoit74
Copy link
Collaborator

benoit74 commented Sep 2, 2024

We should also check that we use the proper visual from https://github.com/offspot/overview/wiki/Visuals (the light one since we do not support dark mode in metrics for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

3 participants