Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Full screen fails to activate #146

Open
chept opened this issue Nov 16, 2024 · 1 comment
Open

[BUG] Full screen fails to activate #146

chept opened this issue Nov 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@chept
Copy link

chept commented Nov 16, 2024

Describe the bug

Full screen sometimes fails to activate after a tiddler was closed while full screen

Expected behavior

No response

To Reproduce

  1. Create a new tiddler and save it (name "Tiddler1").
  2. Create another new tiddler. In this new tiddler activate full screen. Immediately quit without saving (press escape while in full screen)
  3. Full screen in "Tiddler1" fails to activate.
  4. To reset, recreate a new tiddler, which will be opened on full screen. Then quit the full screen from this new tiddler. You can now activate full screen on "Tiddler1".

Also happens (but maybe not every time) with existing tiddlers. For example on your demo :

  1. Open tiddler "$:/config/AutoFocus". Activate fullscreen. Immediately quit (press escape while full screen)
  2. Open "GettingStarted". Full screen fails to activate.
  3. Open "$:/config/AutoFocus" which will be full screen. Deactivate full screen.
  4. Full screen can now be activated in "GettingStarted"

Screenshots

No response

Configuration

Tested on local with tiddlydesktop 0.0.18
and on your demo : https://oeyoews.github.io/tiddlywiki-codemirror6/ with firefox 128.4.0esr

Additional context

It looks like a full screen state saved somewhere and not reset when quitting a tiddler.

I am not experienced enough to help more.

@chept
Copy link
Author

chept commented Nov 16, 2024

This is definitely a state issue because when the bug appears, deleting all tiddlers named $:/state/codemirror-6/fullscreen/Draft of ... solves the problem

@oeyoews oeyoews added the bug Something isn't working label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants