Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH.pm probe init is hard-coded to use 127.0.0.1 #431

Open
FliesLikeABrick opened this issue Jan 30, 2025 · 2 comments
Open

SSH.pm probe init is hard-coded to use 127.0.0.1 #431

FliesLikeABrick opened this issue Jan 30, 2025 · 2 comments

Comments

@FliesLikeABrick
Copy link
Contributor

SSH.pm performs a hard-coded test against 127.0.0.1, presumably as a positive control to prove that ssh-keyscan operates as-expected and assuming that 127.0.0.1 is a known-good target to perform this test.

However, if smokeping is running in a container or other (hardened resource such as an Internet-facing slave/poller without SSH running, etc) environment that does not have openssh listening on 127.0.0.1 -- this test fails and Smokeping fails to start.

The documentation does not clarify the purpose of this test, so I am stating that assumption above about why this test is performed in the first place (as a blocking/mandatory part of Smokeping's daemon start-up)

Ideally:

  • This startup test would be more configurable, either making it optional or allowing the target to be specified
  • documentation would clarify the reason this test is performed on startup
FliesLikeABrick pushed a commit to FliesLikeABrick/SmokePing that referenced this issue Jan 30, 2025
@FliesLikeABrick
Copy link
Contributor Author

Linked PR is open @oetiker - we would love to get this in upstream to avoid (or reduce the urgency of) creating an internal fork for our environment

FliesLikeABrick pushed a commit to FliesLikeABrick/SmokePing that referenced this issue Jan 30, 2025
@FliesLikeABrick
Copy link
Contributor Author

PR is at #432

oetiker added a commit that referenced this issue Feb 5, 2025
* Fixes 431 by offering configurable startup host for testing SSH probe

* Documentation enhancement for #431

* CHANGES update for #431 #432

* Update SSH.pm

add missing ,

---------

Co-authored-by: Ryan Rawdon <[email protected]>
Co-authored-by: Tobias Oetiker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant