Skip to content

Commit 4d8a67f

Browse files
committed
[FIX] util/models: Fix UpgradeError
if model is remove but related to that data is still in upgrade_test_data so it failing because here in expected https://github.com/odoo/upgrade-util/blob/e6f36d0d5f3c42453876b046d3d6a2ba39403a40/src/base/0.0.0/end-moved0.py#L13 getting the records of that model which is removed in ``expected`` and in ``value`` we are not getting values of which model is removed that is why below mentioned traceback is rasied for fixing it cleaning up the data from value in ``upgrade_test_data`` ``` Traceback (most recent call last): File "/home/odoo/src/odoo/11.0/odoo/service/server.py", line 1054, in preload_registries registry = Registry.new(dbname, update_module=update_module) File "/home/odoo/src/odoo/11.0/odoo/modules/registry.py", line 85, in new odoo.modules.load_modules(registry._db, force_demo, status, update_module) File "/home/odoo/src/odoo/11.0/odoo/modules/loading.py", line 391, in load_modules migrations.migrate_module(package, 'end') File "/home/odoo/src/odoo/11.0/odoo/modules/migration.py", line 202, in migrate_module migrate(self.cr, installed_version) File "/home/odoo/src/odoo/11.0/odoo/addons/base/maintenance/migrations/base/0.0.0/end-moved0.py", line 19, in migrate % "\n".join("\t- %s.%s" % m for m in sorted(moved_fields)) odoo.addons.base.maintenance.migrations.util.exceptions.UpgradeError: New `moved0` field. It happen when the ORM cannot change a column type by itself. ``` upg-2797343 opw-4800416 closes #273 Signed-off-by: Christophe Simonis (chs) <[email protected]>
1 parent 8ae6e53 commit 4d8a67f

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/base/0.0.0/end-moved0.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ def migrate(cr, version):
1111

1212
cr.execute("SELECT value FROM upgrade_test_data WHERE key = %s", [pre.KEY])
1313
expected = [tuple(i) for i in cr.fetchone()[0]] if cr.rowcount else []
14-
value = pre.get_moved0_columns(cr)
15-
if value != expected:
16-
moved_fields = set(value) - set(expected)
14+
moved_fields = set(pre.get_moved0_columns(cr)) - set(expected)
15+
if moved_fields:
1716
raise util.UpgradeError(
1817
"New `moved0` field. It happen when the ORM cannot change a column type by itself.\n%s"
1918
% "\n".join("\t- %s.%s" % m for m in sorted(moved_fields))

0 commit comments

Comments
 (0)