[IMP] estate: add unit tests for property business logic

rvar-odoo · rvar-odoo · commit 6054f0de4d5c · 2025-07-17T16:14:10.000+05:30
- Introduced new unit tests in the estate module covering key business processes:
- Prevent offer creation on sold properties.
- Disallow marking properties as sold without an accepted offer.
- Ensure garden area and orientation fields reset appropriately when garden is
unchecked.
-Fix linter issues and apply code review suggestions.
- These tests improve the reliability and maintainability of the estate workflow.
diff --git a/estate/__manifest__.py b/estate/__manifest__.py
@@ -12,7 +12,7 @@
         "security/ir.model.access.csv",
         "views/estate_property_offer_views.xml",
         "views/estate_property_views.xml",
-        "views/estate_settings_views.xml",
+        "views/estate_property_types_views.xml",
         "views/estate_property_tags_views.xml",
         "views/res_users_views.xml",
         "views/estate_menus.xml",
diff --git a/estate/demo/estate_offer_demo.xml b/estate/demo/estate_offer_demo.xml
@@ -5,7 +5,6 @@
         <field name="price">1500000</field>
         <field name="validity">14</field>
         <field name="date_deadline" eval="datetime.now().date() + timedelta(days=14)"/>
-
     </record>
 
     <record id="estate_offer_azure_2" model="estate.property.offer">
@@ -14,7 +13,6 @@
         <field name="price">1500001</field>
         <field name="validity">14</field>
         <field name="date_deadline" eval="datetime.now().date() + timedelta(days=14)"/>
-
     </record>
 
     <record id="estate_offer_deco" model="estate.property.offer">
@@ -23,7 +21,6 @@
         <field name="price">1500002</field>
         <field name="validity">14</field>
         <field name="date_deadline" eval="datetime.now().date() + timedelta(days=14)"/>
-
     </record>
 
     <function model="estate.property.offer" name="action_accept">
@@ -38,6 +35,3 @@
         <value eval="[ref('estate.estate_offer_deco')]"/>
     </function>
 </odoo>
-
-
-
diff --git a/estate/demo/estate_property_demo.xml b/estate/demo/estate_property_demo.xml
@@ -1,5 +1,4 @@
 <odoo>
-
     <record id="estate_property_big_villa" model="estate.property">
         <field name="name">Big Villa</field>
         <field name="state">new</field>
@@ -51,7 +50,6 @@
         <field name="garden_area">50</field>
         <field name="garden_orientation">east</field>
         <field name="property_type_id" ref="estate.property_type_residential"/>
-
         <field name="offer_id">
             <record model="estate.property.offer">
                 <field name="partner_id" ref="base.res_partner_10"/>
@@ -68,7 +66,7 @@
         </field>
     </record>
 
- <record id="estate_property_very_samll_house" model="estate.property">
+    <record id="estate_property_very_samll_house" model="estate.property">
         <field name="name">Very Small House</field>
         <field name="state">new</field>
         <field name="description">A nice and small villa</field>
@@ -84,7 +82,6 @@
         <field name="garden_area">100000</field>
         <field name="garden_orientation">south</field>
         <field name="property_type_id" ref="estate.property_type_residential"/>
-
         <field name="offer_id" eval="[
             Command.create({
                 'partner_id': ref('base.res_partner_12'),
@@ -106,9 +103,4 @@
             })
         ]"/>
     </record>
-
-   
-
-
-
 </odoo>
diff --git a/estate/models/__init__.py b/estate/models/__init__.py
@@ -4,4 +4,4 @@
 from . import estate_property_type
 from . import estate_property_tag
 from . import estate_property_offer
-from . import inherited_model
+from . import inherited_res_users
diff --git a/estate/models/estate_property.py b/estate/models/estate_property.py
@@ -97,6 +97,10 @@ def _onchange_garden(self):
 
     def action_property_sold(self):
         for prop in self:
+            accepted_offer = prop.offer_id.filtered(lambda i : i.status == 'accepted')
+            if not accepted_offer:
+                raise ValidationError(_("Cannot mark as sold. No accepted offer found for this property."))
+            
             if prop.state == "cancelled":
                 raise UserError(_("Cancelled properties cannot be sold."))
             prop.state = "sold"
diff --git a/estate/models/estate_property_offer.py b/estate/models/estate_property_offer.py
@@ -85,6 +85,11 @@ def create(self, vals_list):
             property_id = vals.get("property_id")
 
             property_rec = self.env["estate.property"].browse(property_id)
+
+            if property_rec.state == "sold":
+                raise exceptions.ValidationError(_("You cannot create an offer for a property that is already sold."))
+
+
             if property_rec.state == "new":
                 property_rec.state = "offer_received"
 
diff --git a/estate/models/inherited_res_users.py b/estate/models/inherited_res_users.py
@@ -1,7 +1,7 @@
 from odoo import models, fields
 
 
-class ResUsers(models.Model):
+class InheritedResUsers(models.Model):
     _inherit = "res.users"
 
     property_ids = fields.One2many(
diff --git a/estate/report/estate_property_report_templates.xml b/estate/report/estate_property_report_templates.xml
@@ -19,6 +19,7 @@
                             <strong>Status: </strong>
                             <span t-field="property.state"/>
                         </div>
+                        <div class="invoice_info"/>
                         <t t-set="object" t-value="property"/>
                         <t t-call="estate.report_property_offers_table"/>
                     </div>
@@ -104,18 +105,12 @@
     </template>
 
     <template id="report_property_offers_inherit_invoice" inherit_id="estate.report_property_offers" priority="20">
-        <xpath expr="//div[hasclass('page')]" position="inside">
+        <xpath expr="//div[hasclass('invoice_info')]" position="inside">
             <t t-if="property.state == 'sold'">
                 <div class="mt-4">
-                    <h4>Invoice Information</h4>
-                    <p>The invoice has already been creted!!!</p>
+                    <p><strong>The invoice has already been creted!!!</strong></p>
                 </div>
             </t>
         </xpath>
     </template>
-
-
-
-    
-
-</odoo>
+</odoo>
diff --git a/estate/report/estate_property_reports.xml b/estate/report/estate_property_reports.xml
@@ -20,5 +20,4 @@
         <field name="binding_type">report</field>
         <field name="print_report_name">'User Properties - %s' % (object.name)</field>
     </record>
-
-</odoo>
+</odoo>
diff --git a/estate/security/estate_security.xml b/estate/security/estate_security.xml
@@ -1,4 +1,3 @@
-<?xml version="1.0" encoding="utf-8"?>
 <odoo>
     <record id="estate_group_user" model="res.groups">
         <field name="name">Agent</field>
@@ -9,7 +8,6 @@
         <field name="name">Manager</field>
         <field name="category_id" ref="base.module_category_real_estate_brokerage"/>
         <field name="implied_ids" eval="[(4, ref('estate.estate_group_user'))]"/> 
-        <!-- This group implies (automatically includes) another group’s rights that is Agent.”-->
     </record>
 
     <record id = "estate_property_agent_rule" model = "ir.rule">
@@ -18,7 +16,7 @@
         <field name="domain_force">['|', ('user_id', '=', False), ('user_id', '=', user.id)]</field>
         <field name="groups" eval="[(4, ref('estate.estate_group_user'))]"/>
     </record>
-    
+
     <record id="estate_property_manager_rule" model="ir.rule">
         <field name="name">Estate: Manager see all properties</field>
         <field name="model_id" ref="estate.model_estate_property"/>
@@ -34,5 +32,4 @@
         <field name="perm_create" eval="True"/>
         <field name="perm_unlink" eval="True"/>
     </record>
-
 </odoo>
diff --git a/estate/tests/__init__.py b/estate/tests/__init__.py
@@ -0,0 +1,3 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from . import test_estate_offer
diff --git a/estate/tests/test_estate_offer.py b/estate/tests/test_estate_offer.py
@@ -0,0 +1,100 @@
+from odoo.tests.common import TransactionCase
+from odoo.exceptions import ValidationError
+from odoo.tests import tagged
+
+
+@tagged("post_install", "-at_install")
+class EstateTestOfferCase(TransactionCase):
+    @classmethod
+    def setUpClass(cls):
+        super(EstateTestOfferCase, cls).setUpClass()
+
+        cls.partner = cls.env["res.partner"].create({"name": "Test Buyer"})
+
+        cls.salesperson = cls.env["res.users"].create(
+            {"name": "Test Salesperson", "login": "test.salesperson@example.com"}
+        )
+
+        cls.property = cls.env["estate.property"].create(
+            {
+                "name": "Test Property",
+                "expected_price": 500000,
+                "state": "new",
+                "user_id": cls.salesperson.id,
+            }
+        )
+
+    def test_cannot_create_offer_on_sold_property(self):
+        """Prevent creating offers for sold property"""
+        self.property.write({"state": "sold"})
+
+        with self.assertRaises(ValidationError):
+            self.env["estate.property.offer"].create(
+                {
+                    "partner_id": self.partner.id,
+                    "property_id": self.property.id,
+                    "price": 510000,
+                    "validity": 10,
+                }
+            )
+
+    def test_cannot_sell_property_without_accepted_offer(self):
+        """Prevent selling property with no accepted offer"""
+        with self.assertRaises(ValidationError) as ctx:
+            self.property.action_property_sold()
+
+        self.assertIn(
+            "Cannot mark as sold. No accepted offer found for this property.",
+            str(ctx.exception),
+        )
+
+    def test_can_sell_property_with_accepted_offer(self):
+        """Allow selling property if accepted offer exists"""
+        offer = self.env["estate.property.offer"].create(
+            {
+                "partner_id": self.partner.id,
+                "property_id": self.property.id,
+                "price": 520000,
+                "validity": 10,
+            }
+        )
+
+        offer.action_accept()
+        self.property.action_property_sold()
+
+        self.assertEqual(
+            self.property.state, "sold", "Property should be marked as sold."
+        )
+        self.assertEqual(
+            self.property.buyer_id.id, self.partner.id, "Buyer should be set correctly."
+        )
+        self.assertEqual(
+            self.property.selling_price,
+            offer.price,
+            "Selling price should match accepted offer price.",
+        )
+        self.assertEqual(
+            self.property.user_id.id,
+            self.salesperson.id,
+            "Salesman should be set correctly.",
+        )
+
+    def test_reset_garden_fields_when_garden_unchecked(self):
+        """Unchecking garden resets garden_area and garden_orientation"""
+        property = self.env["estate.property"].create(
+            {
+                "name": "Test Villa",
+                "expected_price": 500000,
+                "garden": True,
+                "garden_area": 500,
+                "garden_orientation": "north",
+            }
+        )
+
+        property.garden = False
+        property._onchange_garden()
+
+        self.assertEqual(property.garden_area, 0, "Garden area should reset to 0")
+        self.assertFalse(
+            property.garden_orientation, "Garden orientation should reset to False"
+        )
diff --git a/estate/views/estate_menus.xml b/estate/views/estate_menus.xml
@@ -1,25 +1,12 @@
 <odoo>
-    <menuitem id="estate_menu_root" 
-    name="Real Estate"> 
-
-        <menuitem id="Advertisement_menu" 
-        name="Advertisement"> 
-            <menuitem id="estate_property_menu_action" 
-            action="estate_property_action"/> 
+    <menuitem id="estate_menu_root" name="Real Estate">
+        <menuitem id="Advertisement_menu" name="Advertisement">
+            <menuitem id="estate_property_menu_action" action="estate_property_action"/>
         </menuitem>
 
-        <menuitem id="Settings_menu" 
-            name="Settings"
-            groups="estate.estate_group_manager"> 
-
-            <menuitem id="estate_property_menu_action_settings" 
-                action="estate_property_action_settings"
-                groups="estate.estate_group_manager"/>
-            
-            <menuitem id="estate_property_menu_action_settings_tag" 
-                action="estate_property_action_tag"
-                groups="estate.estate_group_manager"/>
-
+        <menuitem id="Settings_menu" name="Settings" groups="estate.estate_group_manager">
+            <menuitem id="estate_property_menu_action_settings_type" action="estate_property_action_types" groups="estate.estate_group_manager"/>
+            <menuitem id="estate_property_menu_action_settings_tag" action="estate_property_action_tag" groups="estate.estate_group_manager"/>
         </menuitem>
     </menuitem>
 </odoo>
diff --git a/estate/views/estate_property_offer_views.xml b/estate/views/estate_property_offer_views.xml
@@ -4,7 +4,6 @@
         <field name="res_model">estate.property.offer</field>
         <field name="view_mode">list</field>
         <field name="domain">[('property_type_id', '=', active_id)]</field>
-
     </record>
 
     <record id="estate_property_offer_list_view" model="ir.ui.view">
@@ -20,5 +19,4 @@
             </list>
         </field>
     </record>
-
 </odoo>
diff --git a/estate/views/estate_property_tags_views.xml b/estate/views/estate_property_tags_views.xml
@@ -4,21 +4,20 @@
         <field name="res_model">estate.property.tag</field>
         <field name="view_mode">list,form</field>
     </record>
-    
+
     <record id="estate_property_settings_tag_form" model="ir.ui.view">
         <field name="name">estate.property.tag.form</field>
         <field name="model">estate.property.tag</field>
         <field name="arch" type="xml">
             <form string="Name">
                 <sheet>
-                        <div class="oe_title">
-                            <h1>
-                                <field name="name" />
-                            </h1>
-                        </div>
+                    <div class="oe_title">
+                        <h1>
+                            <field name="name" />
+                        </h1>
+                    </div>
                 </sheet>
             </form>
         </field>
     </record>
-
 </odoo>
diff --git a/estate/views/estate_property_types_views.xml b/estate/views/estate_property_types_views.xml
diff --git a/estate/views/estate_property_views.xml b/estate/views/estate_property_views.xml
diff --git a/estate/views/res_users_views.xml b/estate/views/res_users_views.xml
