[IMP] Enable pg_vector on databases newly created

The PostgresSQL extension `vector` is required for Odoo to work with AI
modules, it must be activated on new databases.

Author: brinkflew

odev/commands/database/create.py

@@ -153,7 +153,10 @@ def create_database(self):
             self._template.connector.disconnect()
 
         with progress.spinner(f"Creating {message}"):
-            created = self._database.create(template=template) & self._database.unaccent() & self._database.pg_trgm()
+            created = self._database.create(template=template)
+            created &= self._database.unaccent()
+            created &= self._database.pg_trgm()
+            created &= self._database.pg_vector()
 
             if created is False:
                 raise self.error(f"Failed to create database {self._database.name!r}")

odev/common/databases/local.py

@@ -11,7 +11,7 @@
 from datetime import datetime
 from functools import cached_property
 from pathlib import Path
-from subprocess import PIPE, CalledProcessError, Popen
+from subprocess import PIPE, Popen
 from time import sleep
 from types import FrameType
 from typing import (
@@ -933,11 +933,10 @@ def _buffered_sql_enable_extensions(self, dump: gzip.GzipFile | bz2.BZ2File | IO
         else:
             self.unaccent()
 
-        self.pg_vector()
         dump.seek(0)
 
     @ensure_connected
-    def unaccent(self):
+    def unaccent(self) -> bool:
         """Install the unaccent extension on the database."""
         unaccent_queries = [
             "CREATE SCHEMA IF NOT EXISTS unaccent_schema",
@@ -968,21 +967,33 @@ def unaccent(self):
         return res
 
     @ensure_connected
-    def pg_trgm(self):
+    def pg_trgm(self) -> bool:
         """Install the pg_trgm extension on the database."""
         pg_trgm_query = "CREATE EXTENSION IF NOT EXISTS pg_trgm WITH SCHEMA public"
         return self.query(pg_trgm_query)
 
-    def pg_vector(self):
-        """Install the pgvector extension on the database."""
-        pgvector_query = "CREATE EXTENSION IF NOT EXISTS vector WITH SCHEMA public"
+    def pg_vector(self) -> bool:
+        """Install the vector extension on the database.
+        Try creating the extension through a regular query first, that will only work if the extension is whitelisted
+        in `pgextwlist` or if the user is owner of the extension. If this fails, try enabling it as the `postgres`
+        user.
+        """
+        pg_vector_query = "CREATE EXTENSION IF NOT EXISTS vector WITH SCHEMA public"
 
         try:
-            return bash.execute(f"sudo -u postgres psql -d {self.name} -c '{pgvector_query}'")
-        except CalledProcessError as error:
-            raise OdevError(
-                "Failed to install pgvector extension, make sure it is installde on your system first"
-            ) from error
+            self.query(pg_vector_query)
+        except RuntimeError:
+            link = string.link(
+                "pgextwlist",
+                "https://github.com/dimitri/pgextwlist?tab=readme-ov-file#postgresql-extension-whitelist",
+            )
+            logger.error(
+                "Failed to install 'pgvector' extension, please ensure it is installed on your system "
+                f"and whitelisted with {link}"
+            )
+            return False
+
+        return True
 
     @ensure_connected
     def neuter_filestore(self):

odev/common/string.py

@@ -293,3 +293,14 @@ def quote(string: str, dirty_only: bool = False, force_single: bool = False) ->
 
     double = not force_single and (index == -1 or string[index] == "'")
     return f'"{string}"' if double else f"'{string}'"
+
+
+def link(text: str, url: str) -> str:
+    """Convert a link to text to be printed in the console.
+
+    :param text: The text to link.
+    :param url: The URL to link to.
+    :return: The link.
+    :rtype: str
+    """
+    return f"[link={url}]{text}[/link]"