[FIX] hr_holidays_attendance: unlink overtime_id if not deductable

This commit fixes a bug that occurs when switching a leave request
of type "Extra Hours" to another time-off type. The issue happens
when editing a leave request that allows deduction from overtime,
as it remains linked to attendance overtime that needs to be unlinked.

task-4756706

closes odoo#216880

X-original-commit: 1b1a085
Signed-off-by: Yannick Tivisse (yti) <[email protected]>
Signed-off-by: Ahmed Taha Abdelaziz (ahta) <[email protected]>

Author: ataha1

addons/hr_holidays_attendance/models/hr_leave.py

@@ -52,6 +52,7 @@ def _check_overtime_deductible(self, leaves):
         # If the type of leave is overtime deductible, we have to check that the employee has enough extra hours
         for leave in leaves:
             if not leave.overtime_deductible:
+                leave.overtime_id.sudo().unlink()
                 continue
             employee = leave.employee_id.sudo()
             duration = leave.number_of_hours_display