Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in completions with 0.2 #12

Open
danburkert opened this issue Sep 27, 2016 · 0 comments
Open

Regression in completions with 0.2 #12

danburkert opened this issue Sep 27, 2016 · 0 comments

Comments

@danburkert
Copy link

Hi,

The completions feature seems to be broken in version 0.2. The completion callback is only passed the most recently word, instead of the full line as in 0.1. 0.2 also adds a runtime dependency on the system's C++ standard library, which hurts portability.

zackmdavis added a commit to zackmdavis/Epilogue that referenced this issue Jul 22, 2018
I'm a little nervous about using this commit introducing rustyline,
because the other week when I tried to go further and implement
completions, I found out that the documentation is full of lies and
the crate appears to be unmaintained. (I wouldn't be so bothered by
one or the other of those, but the conjunction gives me pause.) But
then I tried to use what appears to be the most popular linenoise
wrapper, and up-arrow history didn't seem to work (even though the
method names in the example code made it look like it would work), and
there's an open issue from 2016 (octplane/rust-linenoise#12) that
looks pretty damning.

So ... let's just let this be on master and maybe swap it out later if
we want completions and really can't make them work in
rustyline. Consider it my karmic punishment for my delinquent
co-maintainership of rusty-machine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant