Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bigger/configurable interval on waitForAqua() (when checking if a DDO is already indexed) #1894

Open
paulo-ocean opened this issue Dec 13, 2024 · 0 comments · May be fixed by #1895
Open
Assignees
Labels
Type: Enhancement New feature or request

Comments

@paulo-ocean
Copy link
Contributor

paulo-ocean commented Dec 13, 2024

Right now, the function waitForAqua which is used whenever we want to check the status of a DDO (for instance on the CLI getDDO command). It does not have a configurable interval to do the checks..
It keeps retrying itself every 1.5 seconds, for a MAX of up to 100 retries... (all hardcoded)
This is kind of pointless if the DDO is taking some time to get indexed..
We should at least double the default interval (so, retry every 3 seconds) and make it a configurable argument for the function. Additionally, the MAX retries could also be configurable
This is also helpful to lower the number of inconsequent requests possible made against the node (which also can post rate/connection limits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants