Try to fix the #526 documentation issue #607
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to Fix #526 (#526 (comment))
Description
Cc @AltGr
I tried solving the
"unknown lib"
issue in https://ocaml.org/p/learn-ocaml/1.0.0/doc/Test_lib/index.htmlby adding
(public_name learn-ocaml.test_lib)
and(public_name learn-ocaml.report)
in thesrc/grader/dune
file.however, this addition recursively required setting several dune stanzas as public libraries (see last commit),
and ultimately, we end up with the following error:
To sum, there were three issues to solve:
learn-ocaml.test_lib
does not seem to be defined currently,despite what is promised at this line:
learn-ocaml/src/grader-plugins/dune
Line 9 in c8174f8
as a result, the published documentation says "undefined lib"
Issue 3:the doc. home page does not mentionMutation_test
→ this is now fixed thanks to bd79ffe updating theindex.mld
file.I suspect that the list of all the modules we'd like to document is here:
learn-ocaml/src/grader/test_lib/dune
Lines 21 to 29 in c8174f8
and that it might suffice to tweak these stanzas:
learn-ocaml/src/grader/dune
Lines 11 to 15 in c8174f8
learn-ocaml/src/grader/dune
Lines 60 to 64 in c8174f8
but currently I'm stuck, @AltGr can you take a look?
Checklist
Note to maintainers
Close #…
if a related issue exists.