Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Improve developer documentation (Learnocaml_api.request) #494

Open
erikmd opened this issue Jul 29, 2022 · 0 comments
Open

Bug: Improve developer documentation (Learnocaml_api.request) #494

erikmd opened this issue Jul 29, 2022 · 0 comments

Comments

@erikmd
Copy link
Member

erikmd commented Jul 29, 2022

Related project scope(s): REST API

Related user(s):

Bug description

The dev. doc. (comments, etc.) of some parts of the codebase (§) is terse and should be extended to ease contributing.

(§) Namely, each constructor of Learnocaml_api.request should come with a summary of its operational semantics:

type _ request =
| Static:
string list -> string request
| Version:
unit -> (string * int) request
| Nonce:
unit -> string request
| Create_token:
string * student token option * string option -> student token request
| Create_teacher_token:
teacher token -> teacher token request
| Fetch_save:
'a token -> Save.t request
| Archive_zip:

Current configuration

  • OS name (and version): N/A
  • Browser name (and version): N/A
  • learn-ocaml --version: master = dd16e46
  • git describe --long --always --abbrev=40 --tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant