-
Notifications
You must be signed in to change notification settings - Fork 114
Strategy for 5.2.0 Unit_info and compunit
Mark Shinwell edited this page Jul 12, 2024
·
6 revisions
This page describes our strategy for merging 5.2.0 with respect to:
- the new
Unit_info
module - the new
compunit
type (e.g.Cmo_format.compunit
).
Places that have Compilation_unit.t
already on our side should stay like that, even if upstream has changed from string
(or some other type) to Unit_info.t
.
Possible change: maybe we should change modname
inside Unit_info
to be of type Compilation_unit.t
.
We're going to try to change things which use Cmo_format.compunit
to use Compilation_unit
instead. This will clean up some existing code (e.g. deleting Compilation_unit.to_global_ident_for_bytecode
).