Skip to content

Conversation

@Forestryks
Copy link
Contributor

@Forestryks Forestryks commented May 7, 2025

Change libloc arguments from -libloc <dir>:<libs>:<hidden_libs> to -I-paths <file> and -H-paths <file>. This removes hardcoding libloc directory structure from compiler and makes it more similar to -I and -H files. We also remove libloc naming completely to make it simpler.

This change is not backwards compatible, but this is completely fine and expected. We don't use libloc anywhere in production yet.

Copy link
Contributor

@gretay-js gretay-js left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other executables such as the ones in extract_externals/extract_externals.ml and toplevel may need to be updated. Maybe search for all the place where include_dirs and hidden_include_dirs are used, if you haven't yet.

@gretay-js gretay-js merged commit 24b7862 into main Jun 3, 2025
28 checks passed
@gretay-js gretay-js deleted the aodintsov-support-individual-libloc-files branch June 3, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants