Refactor lattice flipping for modes #3949
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riaqn
commented
May 2, 2025
Comment on lines
-2932
to
-2933
| | Meet_with : 'a -> (('a, 'l * 'r) mode_comonadic, 'a) raw | ||
| | Join_with : 'a -> (('a, 'l * 'r) mode_monadic, 'a) raw |
There was a problem hiding this comment.
This GADT was intended to encode the fact that Meet_with can be only applied on comonadic axes, to remove the assertion at L2988. But it doesn't seem to be work, so I'm simplify it.
riaqn
commented
May 2, 2025
Comment on lines
+2339
to
+2341
| type ('a, 'd0, 'd1) t = | ||
| | Monadic : (Monadic.Const.t, 'a) Axis.t -> ('a, 'd, 'd neg) t | ||
| | Comonadic : (Comonadic.Const.t, 'a) Axis.t -> ('a, 'd, 'd pos) t |
There was a problem hiding this comment.
TBH the new GADT doesn't seem much simpler than before, but at least it no longer mentions mode_monadic and mode_comonadic, and instead uses allowance to encode flipping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in
solver.mlthere isSolver_monowhich can handle monotone morphisms. Based on that, there are two polarized solversPositiveandNegative, used for comonadic and monadic axes respectively. The intention is such that user code (mode.ml) doesn't need to think about the flipping. This has two issues:mode.mlstill needs to think about the flipping in some definitions but not all of them. This mixture, and the fact that bothmode.mlandsolver.mlhandles flipping, makes the code more confusing.Positive.tandNegative.tare different types and complicates type polymorphism. In particular,Value.Axis.tis a complicated GADT.So we remove both
PositiveandNegative, and letmode.mlto be the only file that cares about flipping. We move some code such that the flipping are concentrated to fewer places.The downside is that code that uses
modemight see(Uniqueness.Const.t, allowed * disallowed) modeinstead of(disallowed * allowed) Uniqueness.t. The two types are the same, but ideally we want to show the latter.Review
Please review by commit.