Remove basic meet #3689
Closed
Remove basic meet #3689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the old/basic meet and makes the new/advanced meet the only and default meet algorithm. The configuration options (`-flambda2-basic-meet`, `-flambda2-advanced-meet`, and the `flambda2-meet-algorithm` OCAMLPARAM) are kept to avoid breaking scripts, but are now silently ignored. Note that the `Meet_and_join_new` module is *NOT* renamed to `Meet_and_join`, and the `Meet_and_join` module simply forwards to `Meet_and_join_new`. This is intentional in order to re-use the same dispatch mechanism for the new join algorithm in oxcaml#3538. This PR also takes the opportunity to clean up the interfaces: - Remove the now unused `meet_env_extension`; - Remove `join` from the `Flambda2_types` interface
bclement-ocp
force-pushed
the
bclement/kill-old-meet
branch
from
2d23086 to
554d401
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the old/basic meet and makes the new/advanced meet the only and default meet algorithm.
The configuration options (
-flambda2-basic-meet,-flambda2-advanced-meet, and theflambda2-meet-algorithmOCAMLPARAM) are kept to avoid breaking scripts, but are now silently ignored.Note that theChanged this because it makes more sense to use different names in #3538.Meet_and_join_newmodule is NOT renamed toMeet_and_join, and theMeet_and_joinmodule simply forwards toMeet_and_join_new. This is intentional in order to re-use the same dispatch mechanism for the new join algorithm in #3538.Meet_and_join_newis now renamed toMeet_and_join.This PR also takes the opportunity to clean up the interfaces:
meet_env_extension;joinfrom theFlambda2_typesinterface