local implies yielding
#3532
Merged
local implies yielding
#3532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinichenko-js
commented
Feb 3, 2025
dkalinichenko-js
force-pushed
the
dkalinichenko/local-implies-yielding
branch
from
0a38111 to
00ad634
Compare
mshinwell
added
the
modes
riaqn
reviewed
Feb 13, 2025
dkalinichenko-js
force-pushed
the
dkalinichenko/local-implies-yielding
branch
from
2f1a8ed to
bdec230
Compare
|
@riaqn I'd appreciate help debugging the divergence between principal and non-principal typing here, I can't figure out why it happens. |
|
The principality issue is because some types (for example, string) is |
lpw25
reviewed
Mar 12, 2025
dkalinichenko-js
force-pushed
the
dkalinichenko/local-implies-yielding
branch
from
bdec230 to
f061df6
Compare
riaqn
reviewed
Mar 28, 2025
|
I changed legacy zapping behavior of |
|
I also changed contents of |
riaqn
reviewed
Mar 31, 2025
|
Fixed the issue you pointed out + print order. |
riaqn
reviewed
Apr 1, 2025
riaqn
approved these changes
Apr 1, 2025
dkalinichenko-js
force-pushed
the
dkalinichenko/local-implies-yielding
branch
from
65e2665 to
1bc5a60
Compare
Gbury
pushed a commit
to Gbury/flambda-backend
that referenced
this pull request
May 27, 2025
* `local` implies `yielding` * accept tests * `yielding` tests * format * dirty fix test change * small improvement * merge fix * fix printing bounds * accept tests * fix the issue with `instance_prim` * Only vary `yielding` with `[@local_opt]` * fixes * tests * fix lazy * format * keep order * fix mixed mode annots * fixes * fix * rebase + accept --------- Co-authored-by: Diana Kalinichenko <[email protected]> Co-authored-by: Zesen Qian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
yieldingmode the default iflocalis set. The change is only limited to syntax parsing and does not change the inference code. To preserve consistency, theglobalmodality/modifier now also impliesunyieldingby default, and[@local_opt]also varies along theyieldingaxis.Subsequent PRs will add
yieldingannotations to the Capsule API and to the Effects API.The printer now displays
stack_allocation return values with@ unyielding, as intended.This change sometimes causes principal and non-principal type inference to diverge when the old syntax for
local_annotations is used. I'm surprised this compiler option affects syntax parsing, but the issue seems benign.