-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to change FullCalendar locale #491
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jaspwr! One comment -- new settings must be added as optional/potentially undefined in the typescript, since old users updating won't have that setting defined. Making that change will likely cause typescript errors where that undefined isn't handled, so after fixing those, I'd be happy to merge this. It would be a great addition!
Should be fixed now. |
I just tested this locally, and I couldn't find |
I had a look at that |
I changed it to add |
Hey @davish, isn't it ready to merge? |
Adds a setting allowing users to change FullCalendar locale and autodetects the users locale for the default setting.
Fixes #355.