Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the users local timezone for non recurring ics events #464

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JMPJNS
Copy link

@JMPJNS JMPJNS commented Jun 17, 2023

This PR is a potential fix to #311 by parsing non recurring ics events in the users current local timezone

@JMPJNS JMPJNS changed the title + use the users local timezone for non recurring ics events Use the users local timezone for non recurring ics events Jun 17, 2023
@@ -1,17 +1,23 @@
import ical from "ical.js";
import { OFCEvent, validateEvent } from "../../types";
import { DateTime } from "luxon";
import { DateTime, DateTimeJSOptions } from "luxon";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use an import type here?

Suggested change
import { DateTime, DateTimeJSOptions } from "luxon";
import { DateTime, type DateTimeJSOptions } from "luxon";

@ngsilverman
Copy link

ngsilverman commented Jan 29, 2024

Hey @JMPJNS ! I have an overlapping change in the works (#539) which also takes into account the timezone set by ICS, perhaps we could combine our efforts in some way? I like your approach of making the zone a function parameter (I just removed it entirely in my PR).

@ArenSH ArenSH mentioned this pull request Jan 30, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants