Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible recurring events beyond weekly recurrence #225

Closed
wants to merge 2 commits into from

Conversation

Jethril
Copy link

@Jethril Jethril commented Dec 9, 2022

Fixes issue #22.

@Jethril
Copy link
Author

Jethril commented Dec 9, 2022

Currently working on the UI.
I will create a basic GUI because PR #113 will require to change it (if merged).

@Jethril
Copy link
Author

Jethril commented Dec 9, 2022

Progression update (currently without CSS) so you can see the fields:
image

@RusticCraftsman
Copy link

RusticCraftsman commented Jan 23, 2023

Progression update (currently without CSS) so you can see the fields: image

would it be possible to go higher than 1 year? i.e things like world cups are 4 years apart each other, so the 1 year would not be useful for that, maybe we could use something like regex or some option like that for advanced users. I have many many cool ideas like these for better integration with other stuff

i would really like to help you on this, unfortunately I'm not understanding the code so i can work on it

@Jethril
Copy link
Author

Jethril commented Jan 24, 2023

would it be possible to go higher than 1 year? i.e things like world cups are 4 years apart each other, so the 1 year would not be useful for that, maybe we could use something like regex or some option like that for advanced users. I have many many cool ideas like these for better integration with other stuff

The UI is quite ugly for now but you can see "on a week basis" and "every 1 week". If you select "on a year basis" you can set it to "every x years".
Would that solve your problem? Or do you meant, for example, every monday and every two years?

@RusticCraftsman
Copy link

would it be possible to go higher than 1 year? i.e things like world cups are 4 years apart each other, so the 1 year would not be useful for that, maybe we could use something like regex or some option like that for advanced users. I have many many cool ideas like these for better integration with other stuff

The UI is quite ugly for now but you can see "on a week basis" and "every 1 week". If you select "on a year basis" you can set it to "every x years". Would that solve your problem? Or do you meant, for example, every monday and every two years?

i was referring to that exactly, events that happen every 2 years or more.

@Jethril
Copy link
Author

Jethril commented Feb 28, 2023

Well, it would require a tricky UI, like this one: https://crontab-generator.org/.
A good point is that the UI would allow to cover the full rrule specification.

What I could propose is to make this MR work as I imagined it, then enhance it (maybe with one more issue?).
@davish what's your opinion on this?

@davish
Copy link
Collaborator

davish commented Mar 18, 2023

Hi @Jethril, sorry for the radio silence, I've been heads-down on PR #303 that just got merged. Unfortunately, #303 rewrote must of the plugin, so this PR is no longer compatible with the architecture of the code. The good news is that for rrule was added as part of #303, so the only work remaining for issue #22 is the GUI. Thank you for your contribution!

@davish davish closed this Mar 18, 2023
@RusticCraftsman
Copy link

Hi @Jethril, sorry for the radio silence, I've been heads-down on PR #303 that just got merged. Unfortunately, #303 rewrote must of the plugin, so this PR is no longer compatible with the architecture of the code. The good news is that for rrule was added as part of #303, so the only work remaining for issue #22 is the GUI. Thank you for your contribution!

I would like to implement the rrule package, but im not understanding how the code works structurally since is mostly uncommented, do you have anything that could help me better understand this code in order to implement it?

@davish
Copy link
Collaborator

davish commented Apr 4, 2023

@Elkellympia, a good place to start would be the architecture guide that was just committed: https://github.com/davish/obsidian-full-calendar/blob/main/src/README.md. The rrule implementation is mostly in interop.ts.

@RusticCraftsman
Copy link

@Elkellympia, a good place to start would be the architecture guide that was just committed: https://github.com/davish/obsidian-full-calendar/blob/main/src/README.md. The rrule implementation is mostly in interop.ts.

Thanks! i think that would be enough, i love your plugin btw!

@RusticCraftsman
Copy link

@Elkellympia, a good place to start would be the architecture guide that was just committed: https://github.com/davish/obsidian-full-calendar/blob/main/src/README.md. The rrule implementation is mostly in interop.ts.

Thanks! i think that would be enough, i love your plugin btw!

So... it was not, this structure is yet to hard for me to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants