Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ⬆️ Update obsidian dependency #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SkepticMystic
Copy link
Collaborator

Possibly breaking, bumping to 3.0.0 in case

  • I agree to the contribution guidelines laid out here in the readme.

Possibly breaking, bumping to 3.0.0 in case
@SkepticMystic SkepticMystic requested a review from a team as a code owner August 29, 2023 12:06
@SkepticMystic SkepticMystic requested review from phibr0 and removed request for a team August 29, 2023 12:06
@SkepticMystic
Copy link
Collaborator Author

@phibr0 based on #36, I've bumped the version to 3.0.0, as a potentially breaking change.
I do not have time (or familiarity with Obsidian anymore) to test. So I think publishing a breaking change version is warning enough.
Once release, perhaps you or @Vinzent03 could make an announcement on the discord?

Copy link
Member

@phibr0 phibr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly im also unsure about this, but making it a major bump should be fine

@Vinzent03
Copy link
Contributor

I'm using the latest branch version, but just a quick reminder that this is still not released 😅

@phibr0
Copy link
Member

phibr0 commented Feb 2, 2024

I think @SkepticMystic needs to publish a new release on npm, not sure how I would do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants