Skip to content

Commit eb0ca82

Browse files
authored
Fix testing under node >= v21 (#2067)
Our tests do not need global.navigator, which is now present on node (https://nodejs.org/en/blog/announcements/v21-release-announce#navigator-object-integration). And, since it's only a getter, upgrading node was breaking the tests with: > TypeError: Cannot set property navigator of #<Object> which has only a getter Note: if we needed to use jsdom.window’s navigator, we could remove node’s version by applying the following snippet: https://github.com/nodejs/node/pull/50310/files
1 parent 4bbad40 commit eb0ca82

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

test/jsdom.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ function withJsdom(run) {
1919
const jsdom = new JSDOM("");
2020
global.window = jsdom.window;
2121
global.document = jsdom.window.document;
22-
global.navigator = jsdom.window.navigator;
2322
global.Event = jsdom.window.Event;
2423
global.Node = jsdom.window.Node;
2524
global.NodeList = jsdom.window.NodeList;
@@ -30,7 +29,6 @@ function withJsdom(run) {
3029
} finally {
3130
delete global.window;
3231
delete global.document;
33-
delete global.navigator;
3432
delete global.Event;
3533
delete global.Node;
3634
delete global.NodeList;

0 commit comments

Comments
 (0)