From d1f488ea9a16134b6f3388b274e53f1b2fe7781d Mon Sep 17 00:00:00 2001
From: Csillag Kristof <csillag@harmacolindor.com>
Date: Wed, 19 Oct 2022 23:20:16 +0200
Subject: [PATCH] Support opening the settings dialog directly from dangerous
 modal dialogs

---
 src/app/components/Modal/index.tsx            | 60 ++++++++++++++++---
 src/app/components/SettingsButton/index.tsx   | 21 +++++--
 .../components/SettingsDialog/slice/index.ts  |  4 ++
 .../SettingsDialog/slice/selectors.ts         |  1 +
 .../components/SettingsDialog/slice/types.ts  |  1 +
 5 files changed, 72 insertions(+), 15 deletions(-)

diff --git a/src/app/components/Modal/index.tsx b/src/app/components/Modal/index.tsx
index fd1d313c75..e30ee22540 100644
--- a/src/app/components/Modal/index.tsx
+++ b/src/app/components/Modal/index.tsx
@@ -1,11 +1,12 @@
 import { createContext, useCallback, useContext, useEffect, useState } from 'react'
-import { Box, Button, Layer, Heading, Paragraph } from 'grommet'
+import { Box, Button, Layer, Paragraph } from 'grommet'
 import { useTranslation } from 'react-i18next'
-import { Alert, Checkmark, Close } from 'grommet-icons'
+import { Alert, Checkmark, Close, Configure } from 'grommet-icons'
 import { ModalHeader } from 'app/components/Header'
 import { AlertBox } from '../AlertBox'
 import { selectAllowDangerousSetting } from '../SettingsDialog/slice/selectors'
-import { useSelector } from 'react-redux'
+import { useDispatch, useSelector } from 'react-redux'
+import { settingsActions } from '../SettingsDialog/slice'
 
 interface Modal {
   title: string
@@ -30,11 +31,29 @@ interface Modal {
 interface ModalContainerProps {
   modal: Modal
   closeModal: () => void
+  hideModal: () => void
 }
 
 interface ModalContextProps {
+  /**
+   * Show a new modal
+   */
   launchModal: (modal: Modal) => void
+
+  /**
+   * Close the current modal
+   */
   closeModal: () => void
+
+  /**
+   * Hide the current modal (with the intention of showing in again later)
+   */
+  hideModal: () => void
+
+  /**
+   * Show the previously hidden modal again
+   */
+  showModal: () => void
 }
 
 interface ModalProviderProps {
@@ -43,7 +62,8 @@ interface ModalProviderProps {
 
 const ModalContext = createContext<ModalContextProps>({} as ModalContextProps)
 
-const ModalContainer = ({ modal, closeModal }: ModalContainerProps) => {
+const ModalContainer = ({ modal, closeModal, hideModal }: ModalContainerProps) => {
+  const dispatch = useDispatch()
   const { t } = useTranslation()
   const confirm = useCallback(() => {
     modal.handleConfirm()
@@ -59,6 +79,10 @@ const ModalContainer = ({ modal, closeModal }: ModalContainerProps) => {
     : mustWaitSecs ?? 0 // For normal, non-dangerous operations, just use what was specified
 
   const [secsLeft, setSecsLeft] = useState(0)
+  const openSettings = () => {
+    hideModal()
+    setTimeout(() => dispatch(settingsActions.setOpen(true)), 100)
+  }
 
   useEffect(() => {
     if (waitingTime) {
@@ -99,9 +123,6 @@ const ModalContainer = ({ modal, closeModal }: ModalContainerProps) => {
           </AlertBox>
         )}
         <Box direction="row" gap="small" justify="between" pad={{ top: 'large' }}>
-          {/* This is a placeholder, so that if we have only one valid button,
-           the Cancel, it should be on the right side, not the left side.*/}
-          {!!forbidden && <span />}
           <Button
             label={t('common.cancel', 'Cancel')}
             onClick={closeModal}
@@ -118,6 +139,9 @@ const ModalContainer = ({ modal, closeModal }: ModalContainerProps) => {
               icon={modal.isDangerous ? <Alert size="18px" /> : <Checkmark size="18px" />}
             />
           )}
+          {forbidden && (
+            <Button label={t('menu.settings', 'Settings')} onClick={openSettings} icon={<Configure />} />
+          )}
         </Box>
       </Box>
     </Layer>
@@ -126,14 +150,32 @@ const ModalContainer = ({ modal, closeModal }: ModalContainerProps) => {
 
 const ModalProvider = (props: ModalProviderProps) => {
   const [modal, setModal] = useState<Modal | null>(null)
+  const [hiddenModal, setHiddenModal] = useState<Modal | null>(null)
   const closeModal = useCallback(() => {
     setModal(null)
   }, [])
+  const hideModal = useCallback(() => {
+    if (!modal) {
+      throw new Error("You can't call hideModal if no model is shown!")
+    }
+    setHiddenModal(modal)
+    setModal(null)
+  }, [modal])
+  const showModal = useCallback(() => {
+    if (modal) {
+      throw new Error("You can't call showModal when a modal is already visible!")
+    }
+    if (!hiddenModal) {
+      return
+    }
+    setModal(hiddenModal)
+    setHiddenModal(null)
+  }, [modal, hiddenModal])
 
   return (
-    <ModalContext.Provider value={{ closeModal, launchModal: setModal }}>
+    <ModalContext.Provider value={{ closeModal, launchModal: setModal, hideModal, showModal }}>
       {props.children}
-      {modal && <ModalContainer modal={modal} closeModal={closeModal} />}
+      {modal && <ModalContainer modal={modal} closeModal={closeModal} hideModal={hideModal} />}
     </ModalContext.Provider>
   )
 }
diff --git a/src/app/components/SettingsButton/index.tsx b/src/app/components/SettingsButton/index.tsx
index 621cdcc1a2..b26c65180b 100644
--- a/src/app/components/SettingsButton/index.tsx
+++ b/src/app/components/SettingsButton/index.tsx
@@ -1,22 +1,31 @@
-import React, { useState } from 'react'
+import React from 'react'
 import { SidebarButton } from '../Sidebar'
 import { Configure } from 'grommet-icons'
 import { useTranslation } from 'react-i18next'
 import { SettingsDialog } from '../SettingsDialog'
+import { selectIsSettingsDialogOpen } from '../SettingsDialog/slice/selectors'
+import { useDispatch, useSelector } from 'react-redux'
+import { settingsActions } from '../SettingsDialog/slice'
+import { useModal } from '../Modal'
 
 export const SettingsButton = () => {
-  const [layerVisibility, setLayerVisibility] = useState(false)
+  const dispatch = useDispatch()
+  const layerVisibility = useSelector(selectIsSettingsDialogOpen)
   const { t } = useTranslation()
+  const { showModal } = useModal()
+  const setLayerVisibility = (value: boolean) => dispatch(settingsActions.setOpen(value))
+  const closeSettings = () => {
+    setLayerVisibility(false)
+    showModal()
+  }
   return (
     <>
       <SidebarButton
         icon={<Configure />}
         label={t('menu.settings', 'Settings')}
-        onClick={() => {
-          setLayerVisibility(true)
-        }}
+        onClick={() => setLayerVisibility(true)}
       />
-      {layerVisibility && <SettingsDialog closeHandler={() => setLayerVisibility(false)} />}
+      {layerVisibility && <SettingsDialog closeHandler={closeSettings} />}
     </>
   )
 }
diff --git a/src/app/components/SettingsDialog/slice/index.ts b/src/app/components/SettingsDialog/slice/index.ts
index 9e1d0a08bd..3ff7f8c237 100644
--- a/src/app/components/SettingsDialog/slice/index.ts
+++ b/src/app/components/SettingsDialog/slice/index.ts
@@ -4,6 +4,7 @@ import { createSlice } from 'utils/@reduxjs/toolkit'
 import { SettingsState } from './types'
 
 export const initialState: SettingsState = {
+  dialogOpen: false,
   allowDangerous: false,
 }
 
@@ -11,6 +12,9 @@ const slice = createSlice({
   name: 'settings',
   initialState,
   reducers: {
+    setOpen(state, action: PayloadAction<boolean>) {
+      state.dialogOpen = action.payload
+    },
     setAllowDangerous(state, action: PayloadAction<boolean>) {
       state.allowDangerous = action.payload
     },
diff --git a/src/app/components/SettingsDialog/slice/selectors.ts b/src/app/components/SettingsDialog/slice/selectors.ts
index d60ea31546..cfd4a7af81 100644
--- a/src/app/components/SettingsDialog/slice/selectors.ts
+++ b/src/app/components/SettingsDialog/slice/selectors.ts
@@ -6,3 +6,4 @@ import { initialState } from '.'
 const selectSlice = (state: RootState) => state.settings || initialState
 
 export const selectAllowDangerousSetting = createSelector([selectSlice], settings => settings.allowDangerous)
+export const selectIsSettingsDialogOpen = createSelector([selectSlice], settings => settings.dialogOpen)
diff --git a/src/app/components/SettingsDialog/slice/types.ts b/src/app/components/SettingsDialog/slice/types.ts
index d8dd1a2c99..e4394c488e 100644
--- a/src/app/components/SettingsDialog/slice/types.ts
+++ b/src/app/components/SettingsDialog/slice/types.ts
@@ -1,3 +1,4 @@
 export interface SettingsState {
+  dialogOpen: boolean
   allowDangerous: boolean
 }