Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a way to follow a SQL db instead of indexing #284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jun 8, 2022

This should allow multiple non-archival instances to share the same
database, with one and only one instance writing to the db.

Fixes: #84

This should allow multiple non-archival instances to share the same
database, with one and only one instance writing to the db.
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #284 (551d26e) into main (6f19a05) will decrease coverage by 1.83%.
The diff coverage is 2.98%.

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   59.84%   58.01%   -1.84%     
==========================================
  Files          35       35              
  Lines        3990     4118     +128     
==========================================
+ Hits         2388     2389       +1     
- Misses       1397     1525     +128     
+ Partials      205      204       -1     
Impacted Files Coverage Δ
conf/config.go 43.47% <ø> (ø)
main.go 8.42% <0.00%> (ø)
indexer/indexer.go 30.25% <3.00%> (-16.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f19a05...551d26e. Read the comment docs.

@Yawning Yawning marked this pull request as ready for review June 29, 2022 17:21
@Yawning Yawning requested review from kostko and ptrus as code owners June 29, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to disable the indexer
1 participant