Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX]: Display token name in TXs to/from smart contracts #1692

Closed
4 of 9 tasks
donouwens opened this issue Jan 15, 2025 · 2 comments
Closed
4 of 9 tasks

[UX]: Display token name in TXs to/from smart contracts #1692

donouwens opened this issue Jan 15, 2025 · 2 comments
Assignees
Labels
ux/design UX/UI Design Change Report

Comments

@donouwens
Copy link
Collaborator

IMPACT

  • High
  • Medium
  • Low

URGENCY

  • Critical
  • Major
  • Medium
  • Minor

PRODUCT ENVIRONMENT

No response

DESCRIPTION OF ISSUE

If a token has a name it will also be displayed in the TX involving the smart contract.

In the link below we link to a ERC-20 smart contract that has a token name ("Nautilus Dataservice NFT"). With this change we will show the token name in the tx details.
https://explorer.oasis.io/testnet/pontusxdev/tx/0x95a87e44b17878b06321187de5579fa9d780411f3c9db5e4a78285a269496a31

Also, consider visual indicators for self-acclaimed named vs names appointed by Oasis.

DEVICE / VIEWPORT

  • Desktop
  • Mobile

STEPS TO REPRODUCE

No response

ALTERNATIVES AND SUGGESTIONS

No response

@donouwens donouwens added the ux/design UX/UI Design Change Report label Jan 15, 2025
@donouwens donouwens self-assigned this Jan 15, 2025
@donouwens
Copy link
Collaborator Author

@csillag - I think this looks good at the moment. The only thing I'd like to point out is that currently, we don't show the address in parentheses, but rather in the tooltip when hovering. When the copy to clipboard icon is clicked it should still copy the address. See below.

Image

With that design pattern in mind, I designed the visual indicators for self-acclaimed and Oasis-appointed icons for the names too.

Oasis-appointed
Image

Self-acclaimed
Image

@tjanez
Copy link
Member

tjanez commented Mar 5, 2025

Design makes sense, this was already implemented in #1773.

@tjanez tjanez closed this as completed Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux/design UX/UI Design Change Report
Projects
None yet
Development

No branches or pull requests

2 participants